In HttpClientSseClientTransport and WebFluxSseClientTransport add a constructor#67
Closed
HarryFQG wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
In HttpClientSseClientTransport and WebFluxSseClientTransport add a constructor#67HarryFQG wants to merge 3 commits intomodelcontextprotocol:mainfrom
HarryFQG wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
add a Constructs
Add a Constructs
Add a Constructs
HarryFQG
changed the title
tzolov
added a commit
that referenced
this pull request
Mar 27, 2025
…, #67) Enhances WebFlux SSE transport implementation with customizable endpoint paths: - Add configurable SSE endpoint support in both client and server transports - Update tests to verify custom SSE endpoint functionality - Implement builder pattern to support the new configuration options Co-authored-by: haidao <wwulfric@gmail.com> Co-authored-by: Harry <34418180+HarryFQG@users.noreply.github.com> Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A constructor in HttpClientSseClientTransport overloading
Motivation and Context
Repair WebMvcSseServerTransport specifies the sseEndpoint, while HttpClientSseClientTransport SSE_ENDPOINT or/sse, finally an error. Below is a screenshot.
How Has This Been Tested?
There are tests. The test steps are as follows:
Step 1. Create WebMvcSseServerTransport and specify sseEndpoint. For example,
"new WebMvcSseServerTransport(new ObjectMapper(), "/myMcp/message", "/mysse");".Step 2.
When creating
"McpSyncClient"objects, we should specify"WebFluxSseClientTransport"or"HttpClientSseClientTransport"object and then you find there the lack of"sseEndpoint"parameter.Step 3. There is
"Java. Lang. RuntimeException: Failed to connect to SSE stream. Unexpected status code: 404"error.If McpClient use WebFluxSseClientTransport will quote
"under Caused by: org.springframework.web.reactive.function.client.WebClientResponseException$NotFound: 404 Not Found from the GET http://localhost:18080/sse "error.Breaking Changes
It isn't necessary
Types of changes
Checklist
Additional context