Testing: use synctest for timing-dependent tests #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted tests with time.After/time.Sleep to use Go 1.25's synctest package in new *_go125_test.go files for instant, deterministic execution. Tests using real I/O remain timing-based. Fixes modelcontextprotocol#680
La002
changed the title
Contributor
Author
Contributor
Author
|
@maciej-kisiel Pushed with the changes discussed here |
maciej-kisiel
requested changes
Feb 2, 2026
Contributor
maciej-kisiel
left a comment
maciej-kisiel
left a comment
There was a problem hiding this comment.
Thank you for the PR and and patience with the review. I added some comments.
Contributor
Author
|
replied to comments @maciej-kisiel |
Contributor
maciej-kisiel
left a comment
maciej-kisiel
left a comment
There was a problem hiding this comment.
Thank you for the changes. There are still 3 unresolved comment threads, please take a look.
Contributor
Author
|
I replied one comment I had missed earlier. For |
maciej-kisiel
approved these changes
Feb 7, 2026
Contributor
maciej-kisiel
left a comment
maciej-kisiel
left a comment
There was a problem hiding this comment.
Thanks for your patience and contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: use synctest for timing-dependent tests
Converted timing-based tests to use Go 1.25's synctest for instant, deterministic execution with simulated time.
Moved converted tests to *_go125_test.go files. Tests using real I/O (exec.Command, httptest) remain timing-based as they require actual system operations.
Fixes #680