Classpath separator on linux is different from windows#4
Open
elijah629 wants to merge 3 commits intominecraft-rs:mainfrom
Open
Classpath separator on linux is different from windows#4elijah629 wants to merge 3 commits intominecraft-rs:mainfrom
elijah629 wants to merge 3 commits intominecraft-rs:mainfrom
Conversation
John71-Off
reviewed
Nov 7, 2023
src/classpath.rs
Outdated
Comment on lines
16
to
20
| #[cfg(target_os = "linux")] | ||
| pub const CLASSPATH_SEP: char = ':'; | ||
|
|
||
| #[cfg(not(target_os = "linux"))] | ||
| pub const CLASSPATH_SEP: char = ';'; |
There was a problem hiding this comment.
Classpath separator for Windows is ;, for Linux and MacOS :
You should use :
#[cfg(not(target_os = "windows"))] // Linux and MacOS
pub const CLASSPATH_SEP: char = ':';
#[cfg(target_os = "windows")] // Windows
pub const CLASSPATH_SEP: char = ';';|
I think it's worth fixing as well let fixed_lib_path = Path::new(&libraries_path).join(lib_path.replace("/", "\\")); |
|
Yes, code should be : let fixed_lib_path = Path::new(&libraries_path).join(lib_path.replace("\\", "/"));or let fixed_lib_path = Path::new(&libraries_path).join(lib_path);as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux systems, the java classpath separator is a colon instead of a semicolon. I have used conditional compilation to set the separator based on the compilation target.