Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 9, 2026

Localized strings should not be concatenated with hardcoded separators. Different languages may use different separators, word order, or phrasing entirely.

Before:

title: `${localize('goto', "Go To")} / ${localize('accept', "Accept")}`

After:

title: localize('gotoAndAccept', "Go To / Accept")

This allows translators to provide the appropriate phrasing for their language rather than being forced to use the English "Foo / Bar" pattern.

Original prompt

This section details on the original issue you should resolve

<issue_title>debt - don't do nls concat</issue_title>
<issue_description>Found this ⬇️. It's better to have a single nls/localize string and not hardcode the /-character. We don't know if all languages use the "Foo / Bar"

title: `${localize('goto', "Go To")} / ${localize('accept', "Accept")}`,
</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix hardcoded character in nls string localization Replace concatenated localize calls with single localize for gutter indicator menu Jan 9, 2026
Copilot AI requested a review from benibenj January 9, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

debt - don't do nls concat

2 participants