Merged
Conversation
Evangelink
approved these changes
Feb 12, 2026
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Fingers crossed that we don't break unknown old scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think it's reasonable to only copy adapter to the output directory without adding it as a reference. When added as a reference, it's passed to the compiler, and it's known by ResolveAssemblyReferences, which ensures we do the right thing especially when it comes to generating binding redirects.
In addition, this gets us a step closer towards having the adapter assemblies just in lib, similar to any other NuGet package. But doing this is technically a breaking change for some legacy projects that rely on the assemblies being packed in a specific directory.
Also the current approach of copying with
PreserveNewestis wrong. It should have beenIfDifferent(which is more recent - and if we want to support older SDK versions that don't haveIfDifferentwe will have to have more complex logic around it). WhenPreserveNewestis used, if user did a build, updated their csproj to downgrade MSTest version, then did a build again, the wrong version will be in output directory, because it has a more recent timestamp.