Rework MSTEST0016 message and description #7258
Open
+293
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the clarity and helpfulness of the MSTEST0016 analyzer diagnostic message and description, addressing issue #5427. The analyzer detects test classes (marked with [TestClass]) that don't contain any test methods.
Changes:
- Rewrote the diagnostic message to be more explicit about the problem and provide actionable suggestions
- Expanded the description to include detailed explanation of what constitutes a test method, exceptions to the rule, and common scenarios where the rule triggers
- Updated all localization (.xlf) files with new source text and marked them for translation review
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Analyzers/MSTest.Analyzers/Resources.resx | Updated the English diagnostic message and description for MSTEST0016 with clearer, more comprehensive text |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.cs.xlf | Updated Czech localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.de.xlf | Updated German localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.es.xlf | Updated Spanish localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.fr.xlf | Updated French localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.it.xlf | Updated Italian localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.ja.xlf | Updated Japanese localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.ko.xlf | Updated Korean localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.pl.xlf | Updated Polish localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.pt-BR.xlf | Updated Brazilian Portuguese localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.ru.xlf | Updated Russian localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.tr.xlf | Updated Turkish localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.zh-Hans.xlf | Updated Simplified Chinese localization file with new source text, marked for translation review |
| src/Analyzers/MSTest.Analyzers/xlf/Resources.zh-Hant.xlf | Updated Traditional Chinese localization file with new source text, marked for translation review |
Youssef1313
reviewed
Jan 20, 2026
Evangelink
commented
Jan 30, 2026
src/Analyzers/MSTest.Analyzers/TestClassShouldHaveTestMethodAnalyzer.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@Evangelink I've opened a new pull request, #7319, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Youssef1313
reviewed
Feb 9, 2026
Comment on lines
+137
to
143
| // Non-static class that inherits assembly attributes from base class - suggest making it static | ||
| if (!classSymbol.IsStatic && hasAssemblyAttributeInBaseClass && baseClassWithAssemblyAttribute is not null) | ||
| { | ||
| context.ReportDiagnostic(classSymbol.CreateDiagnostic(TestClassShouldHaveTestMethodRule, classSymbol.Name)); | ||
| context.ReportDiagnostic(classSymbol.CreateDiagnostic(TestClassShouldHaveTestMethodRuleBaseClassHasAssemblyAttributes, classSymbol.Name, baseClassWithAssemblyAttribute.Name)); | ||
|
|
||
| return; | ||
| } |
Member
There was a problem hiding this comment.
I'm not sure if this is really addressing the original reported complaint.
Per the description in the linked DC ticket, I think a repro would be something like this:
[TestClass]
public abstract class TestClass
{
[AssemblyInitialize]
public static void M(TestContext _) { }
}So, asm init is in the same class being analyzed. Given that the class doesn't have any non-static members, the correct action user needs to take is to mark the class static instead of abstract, and they don't need to inherit from it anywhere.
A different scenario to consider in this case is when the abstract class have other non-static members. In this case, we might have two options:
- Not report a diagnostic at all and consider it okay.
- Report a diagnostic and suggest that the fixtures get moved to a different class that is marked as static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #5427