Adds Builder and VM Manager interfaces + implementation for UVM #2597
+1,566
−851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the UVM code to clearly separate responsibilities across the VM layers (builder vs. vmmanager) and document the intended architecture. This reorganizes the former `internal/vm/hcs` package into focused builder and manager packages and updates the core interfaces/types. Key changes: - Introduce `internal/vm/builder` as the concrete `Builder` implementation for constructing HCS compute system documents. - Add `internal/vm/vmmanager` package for host-side UVM lifecycle and resource management; move HCS-backed managers here. - Replace the old `UVMBuilder` with a `Builder` interface and manager sub-interfaces for memory/processor/numa/device/boot/storage QoS. - Consolidate shared VM types and errors into `internal/vm/builder_types.go` (guest OS, memory backing, processor config, device IDs). - Add the `internal/vm/README.md` describing the 3-layer VM model and typical usage flow. - Move HCS-specific implementations into their new packages; delete obsolete `internal/vm/hcs` files and rename movers (boot/memory/network/etc.). - Normalize builder APIs to be configuration setters (no errors where Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor and formalization of the Utility VM (UVM) builder and management interfaces. It separates the responsibilities for VM configuration, host-side management, and guest-side actions into clear, testable layers. The changes include a new, well-documented builder interface, VM manager interface, concrete builder and VM manager implementations, along with comprehensive unit tests for the builder's functionality.
The most important changes are:
Architectural Refactor and Documentation
README.mdto theinternal/vmpackage, clearly explaining the separation of concerns between the Builder, VM Manager, and Guest Manager layers, and documenting the responsibilities and flow for each layer.Builder Interface and Implementation
UVMBuilderinterface with a new, comprehensiveBuilderinterface ininternal/vm/builder.go, providing modular access to memory, processor, NUMA, device, boot, and storage QoS configuration managers.Builderinterface ininternal/vm/builder/builder.gofor creating and configuringhcsschema.ComputeSystemdocuments.VM Manager Interface and Implementation
Testing
These changes establish a foundation for future VM configuration and management features.