-
Notifications
You must be signed in to change notification settings - Fork 276
support both cimfs and cimwriter dlls #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anmaxvl
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
anmaxvl:cimfs-backward-compat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ccfeab to
47570f0
Compare
47570f0 to
36bea94
Compare
helsaawy
reviewed
Jan 14, 2026
Contributor
helsaawy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits in comments; but LGTM overall
helsaawy
approved these changes
Jan 20, 2026
97f02b3 to
2589b91
Compare
helsaawy
approved these changes
Jan 20, 2026
The PR introducing cimwriter.dll was a breaking change, which is fixed in this PR. Add both cimfs.dll and cimwriter.dll syscalls and only use cimwriter.dll when present. Signed-off-by: Maksim An <maksiman@microsoft.com>
6070070 to
b61bbd6
Compare
helsaawy
approved these changes
Feb 9, 2026
Signed-off-by: Maksim An <maksiman@microsoft.com>
b61bbd6 to
a9415b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introducing cimwriter.dll was a breaking change, which is fixed in this PR.
Add both cimfs.dll and cimwriter.dll syscalls and only use cimwriter.dll when present.