Skip to content

Clean up GitOps workflows and policies#1986

Open
flanakin wants to merge 3 commits intodevfrom
flanakin/gitops-cleanup
Open

Clean up GitOps workflows and policies#1986
flanakin wants to merge 3 commits intodevfrom
flanakin/gitops-cleanup

Conversation

@flanakin
Copy link
Collaborator

🛠️ Description

Clean up and consolidate GitOps workflows and policies:

  • Reviewer updates: Replace arthurclares with msbrett as default reviewer, add special handling for features/wacoascripts branch, remove inactive contributors (Robel, Divyadeep, Sacha, Ivan, Seif)
  • CODEOWNERS: Updated to match reviewer changes
  • Policy fixes: Fixed label typo (Skill: Workbooks → Tool: Workbooks), removed stale TODO, auto-close duplicate issues
  • Deleted fabricbot.json: Deprecated file with duplicate/unused rules

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Public docs in docs-mslearn (required for dev)
  • ✅ Internal dev docs in docs-wiki (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

- Update reviewer assignments in pulls-02-reviewers.yml
  - Replace arthurclares with msbrett as default reviewer for all PRs
  - Add special handling for features/wacoascripts branch (Arthur only, or Brett/Michael if Arthur is author)
  - Remove inactive reviewers: ro100e, didayal-msft, springstone, ivanmtta, sebassem
  - Add arthurclares as reviewer for Optimization workbook PRs
- Update CODEOWNERS to match reviewer changes
- Fix label typo in issues-00-conventions.yml (Skill: Workbooks → Tool: Workbooks)
- Clean up issues-01-new.yml (remove stale TODO comment)
- Update issues-02-duplicate.yml to close issues instead of assigning to author
- Delete fabricbot.json (deprecated, functionality covered by policies)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 11, 2026 06:35
@flanakin flanakin requested review from a team and arthurclares as code owners February 11, 2026 06:35
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Feb 11, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Skill: DevOps GitHub setup and automation label Feb 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up and consolidates the repository’s GitOps automation by updating reviewer/ownership rules and refining issue management policies to reflect current maintainers and workflows.

Changes:

  • Updated PR reviewer assignment rules (including special handling for features/wacoascripts) and removed inactive reviewers.
  • Adjusted issue policies (fix label taxonomy for Workbooks, add welcome message on new issues, auto-close duplicates).
  • Removed deprecated .github/fabricbot.json and updated .github/CODEOWNERS to align with the new ownership model.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/policies/pulls-02-reviewers.yml Updates automated reviewer assignment rules and removes inactive reviewers.
.github/policies/issues-02-duplicate.yml Adds automatic closing behavior for issues flagged as duplicates.
.github/policies/issues-01-new.yml Updates new-issue behavior to add a welcome comment.
.github/policies/issues-00-conventions.yml Fixes label taxonomy for Workbooks (SkillTool).
.github/fabricbot.json Deletes deprecated/duplicate FabricBot configuration.
.github/CODEOWNERS Updates code ownership mappings to match new reviewer/maintainer coverage.


# \* @microsoft/finops-toolkit

- @flanakin @msbrett
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS entries must start with a file pattern (for the global rule this is typically *). The current line starts with -, which will be treated as a literal path pattern and effectively breaks the intended global ownership rule.

Suggested change
- @flanakin @msbrett
* @flanakin @msbrett

Copilot uses AI. Check for mistakes.
@flanakin flanakin added this to the v14 milestone Feb 11, 2026
flanakin and others added 2 commits February 11, 2026 03:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Skill: DevOps GitHub setup and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants