Open
Conversation
- Update reviewer assignments in pulls-02-reviewers.yml - Replace arthurclares with msbrett as default reviewer for all PRs - Add special handling for features/wacoascripts branch (Arthur only, or Brett/Michael if Arthur is author) - Remove inactive reviewers: ro100e, didayal-msft, springstone, ivanmtta, sebassem - Add arthurclares as reviewer for Optimization workbook PRs - Update CODEOWNERS to match reviewer changes - Fix label typo in issues-00-conventions.yml (Skill: Workbooks → Tool: Workbooks) - Clean up issues-01-new.yml (remove stale TODO comment) - Update issues-02-duplicate.yml to close issues instead of assigning to author - Delete fabricbot.json (deprecated, functionality covered by policies) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up and consolidates the repository’s GitOps automation by updating reviewer/ownership rules and refining issue management policies to reflect current maintainers and workflows.
Changes:
- Updated PR reviewer assignment rules (including special handling for
features/wacoascripts) and removed inactive reviewers. - Adjusted issue policies (fix label taxonomy for Workbooks, add welcome message on new issues, auto-close duplicates).
- Removed deprecated
.github/fabricbot.jsonand updated.github/CODEOWNERSto align with the new ownership model.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/policies/pulls-02-reviewers.yml | Updates automated reviewer assignment rules and removes inactive reviewers. |
| .github/policies/issues-02-duplicate.yml | Adds automatic closing behavior for issues flagged as duplicates. |
| .github/policies/issues-01-new.yml | Updates new-issue behavior to add a welcome comment. |
| .github/policies/issues-00-conventions.yml | Fixes label taxonomy for Workbooks (Skill → Tool). |
| .github/fabricbot.json | Deletes deprecated/duplicate FabricBot configuration. |
| .github/CODEOWNERS | Updates code ownership mappings to match new reviewer/maintainer coverage. |
|
|
||
| # \* @microsoft/finops-toolkit | ||
|
|
||
| - @flanakin @msbrett |
There was a problem hiding this comment.
CODEOWNERS entries must start with a file pattern (for the global rule this is typically *). The current line starts with -, which will be treated as a literal path pattern and effectively breaks the intended global ownership rule.
Suggested change
| - @flanakin @msbrett | |
| * @flanakin @msbrett |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Clean up and consolidate GitOps workflows and policies:
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?