-
Notifications
You must be signed in to change notification settings - Fork 603
DO NOT MERGE, testing spec review action #15787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: damcilva/test_build_2
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds/adjusts RPM spec content under base/comps/ to exercise the spec review workflow, including introducing a new go-md2man spec and updating an EOL-date TODO comment in azurelinux-release.
Changes:
- Add a new local RPM spec for
go-md2man. - Update the
eol_dateTODO comment inazurelinux-release.spec.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| base/comps/go-md2man/go-md2man.spec | Introduces a new RPM spec for building/installing the go-md2man tool. |
| base/comps/azurelinux-release/azurelinux-release.spec | Tweaks the comment describing how eol_date should be set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| %define is_development 1 | ||
|
|
||
| # TODO(azl): review | ||
| # TODO(azl): review -- set to a future date for now, fix before release |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated comment says eol_date is set to a future date, but the value remains 1900-01-01 (a past placeholder). Please adjust the comment to match the actual placeholder semantics, or update eol_date to the intended future date so the file is self-consistent.
| # TODO(azl): review -- set to a future date for now, fix before release | |
| # TODO(azl): review -- set to a placeholder past date for now, fix before release |
|
|
||
| %description | ||
| Converts markdown into roff (man pages) | ||
|
|
||
| %define OUR_GOPATH %{_topdir}/.gopath | ||
| Vendor: Microsoft Corporation | ||
| Distribution: Azure Linux | ||
|
|
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The %description section currently includes RPM metadata/macros (%define OUR_GOPATH ..., and the Vendor:/Distribution: lines). Vendor/Distribution here become part of the package description text, and keeping %define OUR_GOPATH inside %description is very error-prone. Move the macro definition back to the header area (before %description) and remove the duplicated Vendor/Distribution lines from the description body.
| %description | |
| Converts markdown into roff (man pages) | |
| %define OUR_GOPATH %{_topdir}/.gopath | |
| Vendor: Microsoft Corporation | |
| Distribution: Azure Linux | |
| %define OUR_GOPATH %{_topdir}/.gopath | |
| %description | |
| Converts markdown into roff (man pages) |
| Summary: Converts markdown into roff (man pages) | ||
| Name: go-md2man | ||
| Version: 2.0.2 | ||
| Release: 1%{?dist} | ||
| License: MIT | ||
| Vendor: Microsoft Corporation | ||
| Distribution: Azure Linux | ||
| Group: Tools/Container | ||
| URL: https://github.com/cpuguy83/go-md2man | ||
| Source0: https://github.com/cpuguy83/go-md2man/archive/v%{version}.tar.gz#/go-md2man-%{version}.tar.gz | ||
| BuildRequires: golang | ||
| BuildRequires: which | ||
| # required packages on install | ||
| Requires: /bin/sh | ||
| Provides: golang-github-cpuguy83-md2man | ||
| Provides: go-go-md2man = %{version}-%{release} | ||
|
|
||
| %description | ||
| Converts markdown into roff (man pages) | ||
|
|
||
| %define OUR_GOPATH %{_topdir}/.gopath | ||
| Vendor: Microsoft Corporation | ||
| Distribution: Azure Linux | ||
|
|
||
| %prep | ||
| %setup -q -n %{name}-%{version} -c | ||
|
|
||
| %build | ||
| export GOPATH=%{OUR_GOPATH} | ||
| export GOCACHE=%{OUR_GOPATH}/.cache | ||
| export CGO_ENABLED=0 | ||
| export GO111MODULE=on | ||
|
|
||
| cd %{_topdir}/BUILD/%{name}-%{version}/go-md2man-%{version} | ||
| go build -mod vendor -o go-md2man | ||
|
|
||
| %install |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new local spec isn’t referenced by any component definition. base/comps/components.toml only loads components via **/*.comp.toml, and there is no go-md2man.comp.toml in this directory, so this package won’t be picked up by azldev/the build.
| Summary: Converts markdown into roff (man pages) | |
| Name: go-md2man | |
| Version: 2.0.2 | |
| Release: 1%{?dist} | |
| License: MIT | |
| Vendor: Microsoft Corporation | |
| Distribution: Azure Linux | |
| Group: Tools/Container | |
| URL: https://github.com/cpuguy83/go-md2man | |
| Source0: https://github.com/cpuguy83/go-md2man/archive/v%{version}.tar.gz#/go-md2man-%{version}.tar.gz | |
| BuildRequires: golang | |
| BuildRequires: which | |
| # required packages on install | |
| Requires: /bin/sh | |
| Provides: golang-github-cpuguy83-md2man | |
| Provides: go-go-md2man = %{version}-%{release} | |
| %description | |
| Converts markdown into roff (man pages) | |
| %define OUR_GOPATH %{_topdir}/.gopath | |
| Vendor: Microsoft Corporation | |
| Distribution: Azure Linux | |
| %prep | |
| %setup -q -n %{name}-%{version} -c | |
| %build | |
| export GOPATH=%{OUR_GOPATH} | |
| export GOCACHE=%{OUR_GOPATH}/.cache | |
| export CGO_ENABLED=0 | |
| export GO111MODULE=on | |
| cd %{_topdir}/BUILD/%{name}-%{version}/go-md2man-%{version} | |
| go build -mod vendor -o go-md2man | |
| %install | |
| # This file previously contained an RPM spec for go-md2man. | |
| # It is intentionally left blank because there is no corresponding | |
| # component definition (.comp.toml) to include it in the azldev build. | |
| # Do not reintroduce a live spec here without also wiring it into | |
| # base/comps/components.toml via a proper *.comp.toml file. |
| URL: https://github.com/cpuguy83/go-md2man | ||
| Source0: https://github.com/cpuguy83/go-md2man/archive/v%{version}.tar.gz#/go-md2man-%{version}.tar.gz | ||
| BuildRequires: golang | ||
| BuildRequires: which |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BuildRequires: which appears to be unused in this spec (no which invocation in any section). Consider dropping it to keep build deps minimal.
| BuildRequires: which |
0f43928 to
a82551f
Compare
618aa38 to
62315cd
Compare
62315cd to
487cc69
Compare
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology