Skip to content

Conversation

@zhangyuan
Copy link

@zhangyuan zhangyuan commented Jan 9, 2026

Context

When Github Connection uses InstallationToken, the task raises error.

Task Name

KubeloginInstallerV0


Description

If the scheme of githubEndpointObject is InstallationToken, return AccessToken


Risk Assessment (Low / Medium / High)

Assess the level of risk and provide reasoning (e.g., scope, impact, backward compatibility).


Change Behind Feature Flag (Yes / No)

No.


Tech Design / Approach

N/A


Documentation Changes Required (Yes/No)

No.

The document incides it supports InstallationToken, actually not. So no updates to documents.

    {
      "name": "gitHubConnection",
      "type": "connectedService:github:OAuth,OAuth2,PersonalAccessToken,InstallationToken,Token",
      "label": "GitHub Connection",
      "defaultValue": "",
      "required": false,
      "helpMarkDown": "A GitHub connection is needed to prevent anonymous requests limits to the Github API for [Azure/kubelogin](https://github.com/azure/kubelogin) from impacting the installation. Leaving this empty may cause failures if the request limit is reached. This connection does not require ANY permissions."
    }

Unit Tests Added or Updated (Yes / No)

No.


Additional Testing Performed

List all other tests performed (manual or automated, including integration, regression, scenario tests, etc.).


Logging Added/Updated (Yes/No)

No.


Telemetry Added/Updated (Yes/No)

No.


Rollback Scenario and Process (Yes/No)

No.


Dependency Impact Assessed and Regression Tested (Yes/No)

No.


Checklist

  • Related issue linked (if applicable)
  • Task version was bumped — see versioning guide
  • Verified the task behaves as expected

@zhangyuan
Copy link
Author

@microsoft-github-policy-service agree

@zhangyuan zhangyuan marked this pull request as ready for review January 9, 2026 06:19
@zhangyuan zhangyuan marked this pull request as draft January 9, 2026 07:53
@zhangyuan
Copy link
Author

zhangyuan commented Jan 9, 2026

I don't have permissions to install non-official tasks to our origination, so I can't validate the change. I'm not sure if Azure DevOps can well handle InstallationToken from Github. Can someone point me how to validate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant