Skip to content

Node24 Migration for DownloadPackageV1, NpmV1 #21655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexVTor wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Node24 Migration for DownloadPackageV1, NpmV1 #21655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c1b483
DownloadPackageV1 Task bump
AlexVTor Dec 31, 2025
1728a1d
NpmV1 In-Place Node24 Migration
AlexVTor Dec 31, 2025
6cb5e38
Update test cases to remove mocha usage
AlexVTor Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 16 additions & 24 deletions Tasks/DownloadPackageV1/Tests/L0.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ describe("Download single file package suite", function() {
tl.rmRF(tempDir);
});

it("downloads nuget file as nupkg and extracts it", (done: MochaDone) => {
it("downloads nuget file as nupkg and extracts it", async () => {
this.timeout(1000);

let tp: string = path.join(__dirname, "L0DownloadNugetPackage.js");

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);

tr.run();
await tr.runAsync();

assert.equal(tl.ls(null, [tempDir]).length, 1, "should have only 1 file.");
const zipPath = path.join(tempDir, "singlePackageName.nupkg");
Expand All @@ -42,18 +42,17 @@ describe("Download single file package suite", function() {
assert(tr.stderr.length === 0, "should not have written to stderr");
assert(tr.succeeded, "task should have succeeded");

done();
});


it("downloads nuget file as nupkg and fails while extracting it", (done: MochaDone) => {
it("downloads nuget file as nupkg and fails while extracting it", async () => {
this.timeout(1000);

let tp: string = path.join(__dirname, "L0DownloadNugetPackage_BadZip.js");

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);

tr.run();
await tr.runAsync();

assert.equal(tl.ls(null, [tempDir]).length, 1, "should have only 1 file.");
const zipPath = path.join(tempDir, "badNupkgPackageName.nupkg");
Expand All @@ -67,18 +66,17 @@ describe("Download single file package suite", function() {
assert(tr.stderr.length === 0, "should not have written to stderr");
assert(tr.failed, "task should have failed");

done();
});


it("resolves package id, then downloads and extracts nuget package.", (done: MochaDone) => {
it("resolves package id, then downloads and extracts nuget package.", async () => {
this.timeout(1000);

let tp: string = path.join(__dirname, "L0DownloadNugetPackageNameResolves.js");

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);

tr.run();
await tr.runAsync();

assert.equal(tl.ls(null, [tempDir]).length, 1, "should have only 1 file.");
const zipPath = path.join(tempDir, "singlePackageName.nupkg");
Expand All @@ -92,17 +90,16 @@ describe("Download single file package suite", function() {
assert(tr.stderr.length === 0, "should not have written to stderr");
assert(tr.succeeded, "task should have succeeded");

done();
});

it("downloads nuget file from project scoped feed as nupkg and extracts it", (done: MochaDone) => {
it("downloads nuget file from project scoped feed as nupkg and extracts it", async () => {
this.timeout(1000);

let tp: string = path.join(__dirname, "L0DownloadNugetProjectScopedPackage.js");

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);

tr.run();
await tr.runAsync();

assert.equal(tl.ls(null, [tempDir]).length, 1, "should have only 1 file.");
const zipPath = path.join(tempDir, "singlePackageName.nupkg");
Expand All @@ -116,17 +113,16 @@ describe("Download single file package suite", function() {
assert(tr.stderr.length === 0, "should not have written to stderr");
assert(tr.succeeded, "task should have succeeded");

done();
});

it("downloads nuget file as nupkg and does not extract it", (done: MochaDone) => {
it("downloads nuget file as nupkg and does not extract it", async () => {
this.timeout(1000);

let tp: string = path.join(__dirname, "L0DownloadNugetPackage_noextract.js");

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);

tr.run();
await tr.runAsync();

assert.equal(tl.ls(null, [tempDir]).length, 0, "no files should be in temp folder.");

Expand All @@ -138,17 +134,16 @@ describe("Download single file package suite", function() {
assert(tr.stderr.length === 0, "should not have written to stderr");
assert(tr.succeeded, "task should have succeeded");

done();
});

it("downloads npm file as tgz and extracts it", (done: MochaDone) => {
it("downloads npm file as tgz and extracts it", async () => {
this.timeout(1000);

let tp: string = path.join(__dirname, "L0DownloadNpmPackage.js");

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);

tr.run();
await tr.runAsync();

assert.equal(tl.ls(null, [tempDir]).length, 1, "should have only 1 file.");
const zipPath = path.join(tempDir, "singlePackageName.tgz");
Expand All @@ -162,22 +157,20 @@ describe("Download single file package suite", function() {
assert(tr.stderr.length === 0, "should not have written to stderr");
assert(tr.succeeded, "task should have succeeded");

done();
});

it("tries to download npm package, but gets download error", (done: MochaDone) => {
it("tries to download npm package, but gets download error", async () => {
this.timeout(1000);

let tp: string = path.join(__dirname, "L0DownloadNpmPackageDownloadError.js");

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);

tr.run();
await tr.runAsync();

assert(tr.stderr.length === 0, "should not have written to stderr");
assert(tr.failed, "task should have failed");

done();
});
});

Expand All @@ -192,14 +185,14 @@ describe("Download multi file package suite", function() {
tl.rmRF(rootDir);
});

it("only downloads jar and pom files from the maven archive and doesn't extract them", (done: Mocha.Done) => {
it("only downloads jar and pom files from the maven archive and doesn't extract them", async () => {
this.timeout(1000);

let tp: string = path.join(__dirname, "L0DownloadMultiFilePackage.js");

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);

tr.run();
await tr.runAsync();

let outputJarPath: string = path.join(destinationDir, "packageName.jar");
let outputPomPath: string = path.join(destinationDir, "packageName.pom");
Expand All @@ -213,6 +206,5 @@ describe("Download multi file package suite", function() {
assert(tr.stderr.length === 0, "should not have written to stderr");
assert(tr.succeeded, "task should have succeeded");

done();
});
});
Loading