Skip to content

Users/davidmiri/fix docker buildkit warnings 17893 #21650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rm-dmiri wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Users/davidmiri/fix docker buildkit warnings 17893 #21650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cef58f0
Fix Docker@2 false warning about empty output with BuildKit (issue #1…
rm-dmiri Dec 30, 2025
c2e07f3
Apply same BuildKit detection fix to DockerV1 task
rm-dmiri Dec 30, 2025
10201ae
Apply BuildKit detection fix to DockerV0, DockerComposeV0, and Docker…
rm-dmiri Dec 30, 2025
2a9d507
Improve BuildKit detection: Add debug logging and unit tests
rm-dmiri Dec 30, 2025
77086f6
Simplify fix: Remove unreliable empty output warning entirely
rm-dmiri Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tasks/DockerComposeV0/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 263,
"Minor": 268,
"Patch": 0
},
"demands": [],
Expand Down
2 changes: 1 addition & 1 deletion Tasks/DockerComposeV0/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 263,
"Minor": 268,
"Patch": 0
},
"demands": [],
Expand Down
6 changes: 2 additions & 4 deletions Tasks/DockerComposeV0/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,15 @@ function getTaskOutputDir(command: string): string {
}

export function writeTaskOutput(commandName: string, output: string): string {
let escapedCommandName = commandName.replace(/[\\\/:\*\?"<>\|]/g, "");
let escapedCommandName = commandName.replace(/[\\\/:*?"<>|]/g, "");
let taskOutputDir = getTaskOutputDir(escapedCommandName);
if (!fs.existsSync(taskOutputDir)) {
fs.mkdirSync(taskOutputDir);
}

let outputFileName = escapedCommandName + "_" + Date.now() + ".log";
let taskOutputPath = path.join(taskOutputDir, outputFileName);
if (fileutils.writeFileSync(taskOutputPath, output) == 0) {
tl.warning(tl.loc('NoDataWrittenOnFile', taskOutputPath));
}
fileutils.writeFileSync(taskOutputPath, output);

return taskOutputPath;
}
2 changes: 1 addition & 1 deletion Tasks/DockerComposeV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 265,
"Minor": 268,
"Patch": 0
},
"demands": [],
Expand Down
2 changes: 1 addition & 1 deletion Tasks/DockerComposeV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 265,
"Minor": 268,
"Patch": 0
},
"demands": [],
Expand Down
6 changes: 2 additions & 4 deletions Tasks/DockerComposeV1/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,15 @@ function getTaskOutputDir(command: string): string {
}

export function writeTaskOutput(commandName: string, output: string): string {
let escapedCommandName = commandName.replace(/[\\\/:\*\?"<>\|]/g, "");
let escapedCommandName = commandName.replace(/[\\\/:*?"<>|]/g, "");
let taskOutputDir = getTaskOutputDir(escapedCommandName);
if (!fs.existsSync(taskOutputDir)) {
fs.mkdirSync(taskOutputDir);
}

let outputFileName = escapedCommandName + "_" + Date.now() + ".log";
let taskOutputPath = path.join(taskOutputDir, outputFileName);
if (fileutils.writeFileSync(taskOutputPath, output) == 0) {
tl.warning(tl.loc('NoDataWrittenOnFile', taskOutputPath));
}
fileutils.writeFileSync(taskOutputPath, output);

return taskOutputPath;
}
2 changes: 1 addition & 1 deletion Tasks/DockerV0/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 265,
"Minor": 268,
"Patch": 0
},
"demands": [],
Expand Down
2 changes: 1 addition & 1 deletion Tasks/DockerV0/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 265,
"Minor": 268,
"Patch": 0
},
"demands": [],
Expand Down
4 changes: 1 addition & 3 deletions Tasks/DockerV0/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ export function writeTaskOutput(commandName: string, output: string): string {

let outputFileName = commandName + "_" + Date.now() + ".txt";
let taskOutputPath = path.join(taskOutputDir, outputFileName);
if (fileutils.writeFileSync(taskOutputPath, output) == 0) {
tl.warning(tl.loc('NoDataWrittenOnFile', taskOutputPath));
}
fileutils.writeFileSync(taskOutputPath, output);

return taskOutputPath;
}
Expand Down
2 changes: 1 addition & 1 deletion Tasks/DockerV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 265,
"Minor": 268,
"Patch": 0
},
"demands": [],
Expand Down
2 changes: 1 addition & 1 deletion Tasks/DockerV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 265,
"Minor": 268,
"Patch": 0
},
"demands": [],
Expand Down
4 changes: 1 addition & 3 deletions Tasks/DockerV1/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,7 @@ export function writeTaskOutput(commandName: string, output: string): string {

let outputFileName = commandName + "_" + Date.now() + ".txt";
let taskOutputPath = path.join(taskOutputDir, outputFileName);
if (fileutils.writeFileSync(taskOutputPath, output) == 0) {
tl.warning(tl.loc('NoDataWrittenOnFile', taskOutputPath));
}
fileutils.writeFileSync(taskOutputPath, output);

return taskOutputPath;
}
Expand Down
4 changes: 2 additions & 2 deletions Tasks/DockerV2/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 2,
"Minor": 265,
"Patch": 1
"Minor": 268,
"Patch": 0
},
"minimumAgentVersion": "2.172.0",
"demands": [],
Expand Down
4 changes: 2 additions & 2 deletions Tasks/DockerV2/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 2,
"Minor": 265,
"Patch": 1
"Minor": 268,
"Patch": 0
},
"minimumAgentVersion": "2.172.0",
"demands": [],
Expand Down
4 changes: 1 addition & 3 deletions Tasks/DockerV2/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ export function writeTaskOutput(commandName: string, output: string): string {

let outputFileName = commandName + "_" + Date.now() + ".txt";
let taskOutputPath = path.join(taskOutputDir, outputFileName);
if (fileutils.writeFileSync(taskOutputPath, output) == 0) {
tl.warning(tl.loc('NoDataWrittenOnFile', taskOutputPath));
}
fileutils.writeFileSync(taskOutputPath, output);

return taskOutputPath;
}