Fix GoToolV0 to conditionally set GOROOT only for Go < 1.9 (#20796) #21633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix GoToolV0 to conditionally set GOROOT only for Go < 1.9
Fixes: #20796
Task Name
GoToolV0
Description
The GoToolV0 task was unconditionally setting the GOROOT environment variable for all Go versions. This is problematic because:
go tool dist testThis behavior differs from the GitHub Actions setup-go task, which correctly only sets GOROOT for Go versions < 1.9.
Solution:
Updated the setGoEnvironmentVariables function to:
Risk Assessment (Low / Medium / High)
Low.
Change Behind Feature Flag (Yes / No)
No.
Tech Design / Approach
Simple change in GOROOT configuration. Conditionally skipped.
Documentation Changes Required (Yes/No)
No.
Unit Tests Added or Updated (Yes / No)
Yes. Added unit tests.
Additional Testing Performed
No.
Logging Added/Updated (Yes/No)
Telemetry Added/Updated (Yes/No)
No.
Rollback Scenario and Process (Yes/No)
Downgrade task version when using the task.
Dependency Impact Assessed and Regression Tested (Yes/No)
Checklist