Skip to content

fix: resolve const-correctness error in ggml-bitnet-mad.cpp #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eon-ic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve const-correctness error in ggml-bitnet-mad.cpp #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ggml-bitnet-mad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ void ggml_vec_dot_i2_i8_s_Nx1(int n, float * s, size_t bs, const void * vx, size
accu[iy] = _mm256_setzero_si256();
}

int8_t * y_col = y + col * by;
const int8_t * y_col = y + col * by;
Copy link

@zvigrinberg zvigrinberg Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following worked for me:

Suggested change
const int8_t * y_col = y + col * by;
int8_t * y_col = (int8_t *)(y + col * by);

But yours also should work off course.


for (int i = 0; i < group32_num; i++) {
const uint8_t *px = x + i * 1024;
Expand Down