[28.x] - Extended texts are not applied when sales invoices are created through recurring billing#6884
Closed
DhavalMore88 wants to merge 31 commits intomicrosoft:releases/28.xfrom
Conversation
Prepares the repository for the next major release cycle by advancing the application version from `28.0.0.0` to `29.0.0.0`. Fixes [AB#622581](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622581) ## Changes - **`.github/AL-Go-Settings.json`** — `repoVersion`: `28.0` → `29.0` - **329 `app.json` files** — updated `version`, `application`, and internal `dependencies[].version` fields from `28.0.0.0` → `29.0.0.0` > `platform` version is intentionally unchanged — it follows an independent versioning scheme. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Miroslav Uhlir (Miroslav Uhlr) <v-mirouhlir@microsoft.com> Co-authored-by: ankosiorek <117844395+ankosiorek@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Update BC Artifact to 29.0.46659.0 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#620871](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/620871)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#620663](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/620663)
…6821) This PR contains the following changes: - Update BCArtifact version. New value: 29.0.46671.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
Create basic setup data in **OnInstallApp** (so when installing the main QM app), not just when opening the setup page. Reclassify the demo data from the Contoso module as Master data instead of Setup data, so it's not installed with the other setup data. Fixes [AB#622281](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622281) Fixes [AB#622184](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622184) Fixes [AB#619949](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/619949) Fixes [AB#622186](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622186)
…(+ 1 more update(s)) (microsoft#6836) This PR contains the following changes: - Update app baselines package version. New value: 28.1.46668.0 - Update translation package version. New value: 28.0.26054.3 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This pr adds a check that ensures that an invalid gtin dont fail the setrange. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#622663](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622663) Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
…ated through recurring billing (microsoft#6724) [AB#622241](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622241) Workitem: [Bug 622241](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/622241): [master] [All-e]Extended texts are not applied when sales invoices are created through recurring billing
Fixes NO app uptake in NAV. Without change app cant be uptake. Fixes [AB#622607](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622607) Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
…tion (microsoft#6237) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Fix a bug that causes an error when creating a new Nemhandel participation and adding network profiles using the Advanced Setup step. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes microsoft#6225 Fixes [AB#621657](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/621657) --------- Co-authored-by: Jesper Schulz-Wedde <JesperSchulz@users.noreply.github.com> Co-authored-by: Pavel Rakalovič <para@continia.com>
#### Summary Remove the outdated remark on the TestManual procedures. #### Work Item(s) Fixes microsoft#5642 Fixes [AB#623059](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623059)
#### Summary Add the new API Versions to Enum Storage Service API Version. See: https://learn.microsoft.com/de-de/rest/api/storageservices/previous-azure-storage-service-versions #### Work Item(s) Fixes microsoft#6645 Fixes [AB#623061](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623061)
…ices (microsoft#6782) Problem: When an non-AL defined index is disabled (turned off) it doesn't exist anymore (neither in Database Index VT or Key VT), so it will no longer exist in the temp table, leading to an error. Solution: Don't attempt to return to the position for non-AL defined indices after disabling them. Instead the position will just be the first index. This PR also adds another page which shows the index's fields and include fields. Fixes [AB#622744](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622744) Example: <img width="1914" height="1258" alt="{E16B2371-6914-41B5-846B-15FEE42DE281}" src="https://github.com/user-attachments/assets/b15c1081-be85-47ad-8db3-36fccb4e541d" /> --------- Co-authored-by: Mads Gram <magram@microsoft.com>
…6867) This PR contains the following changes: - Update BCArtifact version. New value: 29.0.46742.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
…rosoft#6847) ### Problem When a fulfillment service location is deleted in Shopify but the corresponding `Shpfy Shop Location` record still exists in Business Central, the `GetLocation` GraphQL query returns `{"data":{"location":null}}`. The code attempted to parse `data.location.fulfillmentService` as a single path, which fails because the null `location` token cannot be traversed to reach `fulfillmentService`. This left a stale record with `Fulfillment Service Id = 0`, causing `UpdateFulfillmentServiceCallbackUrl` to proceed with an invalid ID in the `UpdateFulfillmentService` GraphQL mutation. ### Solution **`GetFulfillmentService`**: Split the JSON parsing into two steps. First resolve `data.location` — if it's null (location no longer exists in Shopify), delete the stale `ShopLocation` record (which cascades to related `Shpfy Shop Inventory` records) and exit. Then separately resolve `fulfillmentService` within the location object. **`UpdateFulfillmentServiceCallbackUrl`**: After calling `GetFulfillmentService`, recheck `Fulfillment Service Id`. If it's still `0` (record was deleted or service couldn't be resolved), exit before attempting the update mutation. This provides defense in depth against calling the Shopify API with an invalid ID. Fixes [AB#622988](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622988)
… group UX (microsoft#6779) - Enable item ledger entry as an inspection source so users can create inspections against open inventory (periodic/stock inspections) - Allow the Schedule Inspection report to be used for bulk creating inspections without requiring a schedule group, not just via job queue - Revert accidental change that bypassed the "please choose a record first" validation in the Create Inspection report - Restore schedule group value when the user declines to create a job queue entry, preventing orphaned schedule groups Fixes [AB#621965](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/621965) --------- Co-authored-by: aldobriansky <aldobriansky@microsoft.com>
….. error when you change a newly create line in a customer subscription contract (microsoft#6713) [AB#621997](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/621997) Workitem: [Bug 621997](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/621997): [master][all-e]"The changes to the subscription line record cannot be saved..." error when you change a newly create line in a customer subscription contract
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes microsoft#6762 [AB#604303](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/604303) Co-authored-by: MilicaDjukic <milicadjukic@microsoft.com>
The certificate SetParameters overload was assigning `Certificate := Certificate` (self-assignment) instead of `Certificate := NewCertificate`, causing certificate-based auth to always send an empty certificate. This will fix authorization with certificate for Microsoft Graph and SharePoint Graph API modules. <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes microsoft#6851 Fixes [AB#623157](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623157)
JesperSchulz
previously approved these changes
Feb 26, 2026
…view - 3fade1e / Related to AB#539394 (microsoft#6878) ## preview Note that when using the preview version of AL-Go for GitHub, we recommend you Update your AL-Go system files, as soon as possible when informed that an update is available. ### Issues - Attempt to start docker service in case it is not running ## v8.3 ### Issues - Issue 2107 Publish a specific build mode to an environment - Issue 1915 CICD fails on releases/26.x branch - '26.x' cannot be recognized as a semantic version string ### The default pull request trigger is changing AL-Go for GitHub is transitioning from the pull_request_target trigger to the more secure pull_request trigger. This is a step we are taking to make AL-Go for GitHub more secure by default. If you are used to working from branches within the repository you may not notice any difference. If you get pull requests from forks, those pull requests will no longer be able to access secrets. If that is blocking for your repository, you will need to update your settings to use the pull_request_target trigger. **How do I revert back to pull_request_target?** Add the following setting to one of your settings files and run the Update AL-Go System Files workflow: ```json "pullRequestTrigger": "pull_request_target" ``` Related to [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…hasn't been updated in the draft page (microsoft#6869) Fixes [AB#623185](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623185) Co-authored-by: Joshua Martínez Pineda <diegojoshuam@microsoft.com>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> - Reviewed newly added and existing keys introduced - Standardized key naming by removing prefixes and renaming keys - Applied IncludedFields where appropriate to optimize index usage and avoid unnecessary key expansion #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#610917](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/610917)
#### Summary Required to uptake the system app agent card part. See https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_git/NAV/pullrequest/240711 #### Work Item(s) Fixes [AB#617049](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617049) Co-authored-by: Joshua Martínez Pineda <diegojoshuam@microsoft.com>
AndersLarsenMicrosoft
previously approved these changes
Feb 27, 2026
…6890) This PR contains the following changes: - Update BCArtifact version. New value: 29.0.46820.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
#### Summary <!-- Provide a general summary of your changes --> Filtering on exact item tracing variation #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#618917](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/618917)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Exposes settings coming from the Server about the tenant feedback settings #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#622864](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622864)
…s-are-not-applied
978f0ea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#623240
Workitem:
Bug 623240: [28.x][All-e]Extended texts are not applied when sales invoices are created through recurring billing