[28.x] Bug 623232: [28.x][BCApps #6850]MS Graph module, fix for Certificate auth#6880
Open
JesperSchulz wants to merge 1 commit intoreleases/28.xfrom
Open
[28.x] Bug 623232: [28.x][BCApps #6850]MS Graph module, fix for Certificate auth#6880JesperSchulz wants to merge 1 commit intoreleases/28.xfrom
JesperSchulz wants to merge 1 commit intoreleases/28.xfrom
Conversation
The certificate SetParameters overload was assigning `Certificate := Certificate` (self-assignment) instead of `Certificate := NewCertificate`, causing certificate-based auth to always send an empty certificate. This will fix authorization with certificate for Microsoft Graph and SharePoint Graph API modules. <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #6851 Fixes [AB#623157](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623157)
|
Issue #6851 is not valid. Please make sure you link an issue that exists, is open and is approved. |
1 similar comment
|
Issue #6851 is not valid. Please make sure you link an issue that exists, is open and is approved. |
darjoo
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The certificate SetParameters overload was assigning
Certificate := Certificate(self-assignment) instead ofCertificate := NewCertificate, causing certificate-based auth to always send an empty certificate.This will fix authorization with certificate for Microsoft Graph and SharePoint Graph API modules.
Work Item(s)
Fixes #6851
Fixes AB#623232