Slice 617394: Move Direct-Transfer related functionalities from Subcontracting app to BaseApp#6768
Slice 617394: Move Direct-Transfer related functionalities from Subcontracting app to BaseApp#6768
Conversation
src/Apps/W1/Subcontracting/App/src/Process/Pageextensions/Transfer/SubcTransferOrder.PageExt.al
Show resolved
Hide resolved
| if SubcManagementSetup."Direct Transfer" then begin | ||
| SubcontractingManagement.CheckDirectTransferIsAllowedForTransferHeader(TransferHeader); | ||
| TransferHeader.Validate("Direct Transfer Posting", "Direct Transfer Post. Type"::"Direct Transfer"); | ||
| TransferHeader.Validate("Direct Transfer", true); |
There was a problem hiding this comment.
I think that we should check here if the direct transfer is enabled in Inventory Setup as well. If this is not the case I think that this validate could lead to an error in the following processes.
In gereral this could be an issue. If somebody wants to transfer some components from a location which requires pick or warehouse shipment I don't know the exact side effects on this.
I think that this should be well tested.
There was a problem hiding this comment.
This will change after moving the direct-transfer code to BaseApp
@SPinkow , there were no tests specific to the direct-transfer functionality in the Subcontracting app but we have implemented necessary tests in the BaseApp where the feature is being moved to. |
2 participants
Summary
This PR removes the changes related to Direct-Transfer from Subcontracting app
Work Item(s)
Fixes AB#617394