Remove usage of Any in Parameters #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves type safety across MCP tool registration services and runtime utilities by replacing generic Any type hints with specific type annotations. The changes make the codebase more maintainable and provide better IDE support and type checking.
Key Changes
- Replaced
Anywithsk.Kernelin Semantic Kernel MCP tool registration service methods - Updated
initial_toolsparameter fromList[Any]toList[MCPStreamableHTTPTool]in Agent Framework service - Implemented proper circular import avoidance pattern using
TYPE_CHECKINGforTurnContextin runtime utility
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libraries/microsoft-agents-a365-tooling-extensions-semantickernel/microsoft_agents_a365/tooling/extensions/semantickernel/services/mcp_tool_registration_service.py | Updated parameter types from Any to sk.Kernel for _validate_inputs and _add_hardcoded_tools_for_server methods; removed unused Any import |
| libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py | Changed initial_tools parameter type from List[Any] to List[MCPStreamableHTTPTool] for better type safety; removed unused Any import |
| libraries/microsoft-agents-a365-runtime/microsoft_agents_a365/runtime/utility.py | Implemented TYPE_CHECKING pattern with forward reference to avoid circular imports while properly typing the context parameter as Optional["TurnContext"] in resolve_agent_identity method |
rahuldevikar761
changed the title
pontemonti
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.