Expose a counter to track RadioLib receive errors #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change counts when readData returns an err code other than RADIOLIB_ERR_NONE. In most cases this is going to be a CRC error. This counter is exposed in the `stats-packets` command, and in the repeater stats payload (4 additional bytes to the payload, which is now 56 bytes with this change. My incompetent robot claims the total payload size is 96 bytes (unverified but probably close).
oltaco
suggested changes
Jan 26, 2026
Contributor
oltaco
left a comment
oltaco
left a comment
There was a problem hiding this comment.
Looks good to me, apart from my minor nitpick but that might just be me being pedantic :)
| void loop() override; | ||
|
|
||
| uint32_t getPacketsRecv() const { return n_recv; } | ||
| uint32_t getPacketsRecvErrors() const { return n_recv_errors; } |
Contributor
There was a problem hiding this comment.
Minor nitpick, should this be getPacketRecvErrors() ?
Contributor
|
Nice, I've been wondering about adding this for a while now. Since our local mesh has grown I'm now seeing a non-negligible amount of -707 in the serial log while doing testing and this would be a great addition to track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change counts when
readDatareturns an err code other thanRADIOLIB_ERR_NONE. This will be a CRC error in most cases, with edge cases such as bad radio settings also incrementing this. A CRC error would be caused by conditions such as collisions, interference, and weak signals.This counter is exposed in the
stats-packetscommand, and in the repeater stats payload as 4 additional bytes added to the end of the structure. The app handles this gracefully.My incompetent robot claims the total payload size is 96 bytes (unverified but probably close).
I intend to use this field in the LetsMesh analyzer to get a better idea of how much impact my repeaters are seeing from collisions/interference.