fix: move EDITOR, VISUAL, BROWSER, and PATH to .zshenv

[maxrantil]

Summary

Fixes maxrantil/vm-infra#115

Moves essential environment variables from .zprofile to .zshenv so aliases work in non-login shells (SSH sessions).

Problem

Issue #72 fixed ZDOTDIR but missed other critical environment variables:

• v alias doesn't work (expands to empty string)
• e alias doesn't work (expands to empty string)
• User scripts in ~/.local/bin aren't found

Root cause: These variables were only in .zprofile (login shells only):

export EDITOR="nvim"    # Used by aliases: v=$EDITOR, e=$EDITOR
export VISUAL="nvim"
export BROWSER="firefox"
export PATH="$HOME/.local/bin:$PATH"

Since SSH sessions are non-login shells, these variables were never set.

Changes

1. Moved to .zshenv (runs for ALL shells):

   • EDITOR, VISUAL, BROWSER (needed for aliases)
   • PATH addition (needed to find user scripts)

2. Updated .zprofile:

   • Added shellcheck directive
   • Fixed SC2155 warnings (separate declare and assign)
   • Added explanatory comment about variable locations
   • Kept less critical variables here (LESSHISTFILE, CARGO_HOME, etc.)

Testing

✅ Tested in VM with non-login shell (SSH):

ssh vm "zsh -c 'echo EDITOR=\$EDITOR'"  # EDITOR=nvim ✅
ssh vm "zsh -i -c 'type v'"             # v is an alias for nvim ✅
ssh vm "zsh -i -c 'type e'"             # e is an alias for nvim ✅
ssh vm "zsh -i -c 'v --version'"        # Opens nvim successfully ✅

✅ All pre-commit hooks passing
✅ Shellcheck warnings fixed

Impact

• Completes the .zshenv fix from fix: add .zshenv for non-login shell support #72
• All aliases now work in SSH sessions
• User scripts accessible in all shell types
• No breaking changes (additive only)

Related

• fix: add .zshenv for non-login shell support #72 - Original .zshenv PR (fixed ZDOTDIR)
• Missing EDITOR/VISUAL/PATH in .zshenv breaks aliases in non-login shells vm-infra#115 - Issue tracking this bug
• Missing .zshenv causes dotfiles to fail in non-login shells vm-infra#114 - Original dotfiles bug report