TC_037_2_CS Fix Offline Start Transaction - Invalid IdTag#437
Open
razvanphp wants to merge 1 commit intomatth-x:mainfrom
Open
TC_037_2_CS Fix Offline Start Transaction - Invalid IdTag#437razvanphp wants to merge 1 commit intomatth-x:mainfrom
razvanphp wants to merge 1 commit intomatth-x:mainfrom
Conversation
When StopTransactionOnInvalidId = false, the dedup of StatusNotification messages is important, OCTT expects Charging, not Preparing + SuspendedEV + Charging.
08b15d7 to
bc924e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When StopTransactionOnInvalidId = false, the dedup of StatusNotification messages is important, OCTT expects Charging, not Preparing + SuspendedEV + Charging.
OCTT Test-Case passes after this change & unit tests pass as well, not sure how else to make github actions happy... we don't have rtti enabled to use dynamic_cast 🙁