Autodivision of a whole country#10
Draft
alexey-zakharenkov wants to merge 5 commits intomapsme:masterfrom
Draft
Conversation
…wm size prediction model - with coastlines, land only area and broader region sizes (up to provinces)
…m size estimation
alexey-zakharenkov
force-pushed
the
country-auto-division
branch
from
257055d to
32844a6
Compare
tatiana-yan
reviewed
May 20, 2021
| def __init__(self, subregions, mwm_size_thr=None): | ||
| assert all(s_data['mwm_size_est'] is not None | ||
| for s_data in subregions.values()) | ||
| self.region_id = region_id |
There was a problem hiding this comment.
save_splitting_to_file в auto_split_debug надо тогда тоже комплектно поменять или, если использовать не планируется, выпилить
сейчас он требует наличия region_id в DisjointClusterUnion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
where mwm size prediction model is extended to handle large regions (up to provinces) and takes into account also coastlines and land only area instead of full area.