Feature Request:GBase8s DB #258 add support GBase8s DB#267
Feature Request:GBase8s DB #258 add support GBase8s DB#267617206652 wants to merge 2 commits intomadelson:masterfrom
Conversation
Feature Request:GBase8s DB madelson#258 add support GBase8s DB
| <Using Remove="System.Net.Http" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Content Include="..\..\..\..\GeneralData.EntityFrameworkCore.GBase.DataProvider.dll" PackagePath="lib\netstandard2.1"> |
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="GeneralData.GBase8s.DataProvider" /> |
| <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageVersion Include="GeneralData.GBase8s.DataProvider" Version="1.0.0.1" /> |
There was a problem hiding this comment.
This library isn't well-established enough for use here (< 1K downloads, < 2 months old).
Looks like Odbc seems to be the more common pattern for GBase interactions in the NuGet world
There was a problem hiding this comment.
I'm sorry for the delayed reply. I've been busy with project matters recently and didn't handle your response in time.
Our product was only recently published on NuGet, but it has actually been in use for a long time. The reason is that our product was not allowed to be released publicly on the internet before. Now, to improve our ecosystem, we have pushed it out recently.
| Console.WriteLine(ex.StackTrace); | ||
| foreach (GbsError err in ((GbsException)ex).Errors) | ||
| { | ||
| Console.WriteLine("Native Error" + err.NativeError); |
|
Thanks for raising this PR @617206652 . After reviewing this and looking into GBase a bit more, I have concerns about being able to take on long-term support for GBase at this time. However, this made me reflect on the fact that of the code written here, the only thing that's really specific to GBase is This led me to come up with a proposal for a new extensibility layer which would basically expose the helpful internals from DistributedLock.Core to any ADO.NET-based implementation in a way that would make implementation very easy. Then the ecosystem would look like this: If this interests you, I think it would be very easy to pivot the work you've done here to become the implementation of the Ado extension layer. |
Overview:
This PR adds support for the GBase8s database.
Key Changes:
Added the GBase8s dialect directory, and the framework has also incorporated the processing procedures for GBase8s.
Related Issue: #258.
Components required for the Windows:
https://www.gbase.cn/download/gbase-8s-1?category=DRIVER_PACKAGE
download:clientsdk_3.6.3_3X3_1_ee39df_WIN2003_x86_32.ZIP
Checklist:
Local tests passed.
No breaking changes identified.