Removes check for lastpos === element.scrolltop Fixes safari bug#7
Open
MaxDavila wants to merge 1 commit intomadebysource:masterfrom
Open
Removes check for lastpos === element.scrolltop Fixes safari bug#7MaxDavila wants to merge 1 commit intomadebysource:masterfrom
MaxDavila wants to merge 1 commit intomadebysource:masterfrom
Conversation
…ready stopping once now > animationStart + duration. This breaks safari scrolls since it returns false whenever lastpos !== element.scrollTop even when the animation is not done
MaxDavila
changed the title
lastpos === element.scrolltop, fixes safari bug
|
Very powerful! |
|
This does fix the problem for Safari 6 (Safari 8.0.2 works fine without this fix), but it removes the "If user scrolls while animation is running, scroll animation would be immediately canceled" feature. |
|
I fixed this issue that doesn't break any features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
animatedScrollTois broken in Safari. Wheneverlastpos !== element.scrolltopit kills theanimationeven before reaching the desired position to scrollto.We are already returning false and stopping the animation once already in
now > animationStart + duration.