Made options for scrollLeft and fix callback bug#11
Open
yanawaro wants to merge 3 commits intomadebysource:masterfrom
Open
Made options for scrollLeft and fix callback bug#11yanawaro wants to merge 3 commits intomadebysource:masterfrom
yanawaro wants to merge 3 commits intomadebysource:masterfrom
Conversation
|
👍 I'd love to see this merged. Is @madebysource still open to PRs for this little gem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I love your little script, useful indeed. But I wanted it to be able to use with horizontal scroll too. I made this modification. I followed you arguments pattern. But actually its better to pass in an option object, its more convenient if in the future some more options could be added.
I also found that if the scroll distance is more than the actual scrolling width the callback doesn't fire, I move the callback when It detects its not animating.