-
Notifications
You must be signed in to change notification settings - Fork 0
Fix board isolation in multiuser implementation #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lstein-master
Are you sure you want to change the base?
Conversation
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
…handling Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
|
@copilot The Additionally |
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
... Fixed the Python test failures in commit 678d9c1: Test fixes:
All Python tests should now pass. For the TypeScript errors about |
Summary
Fixes three board isolation issues in multiuser: admin users couldn't see all boards, uncategorized images were shared across users, and board state persisted when switching users.
Backend:
is_adminparameter to board queries - admins now see all boards, regular users see own + shareduser_idfiltering to uncategorized image queries - filters byimages.user_idwhenboard_id == "none"owner_usernametoBoardDTOfor admin visibilityFrontend:
selectedBoardId,autoAddBoardId,boardSearchText) on logout viaextraReducersTests:
is_adminparameter for board queriesBoardRecordobjects to include requireduser_idfieldExample - Admin Board Query:
Related Issues / Discussions
See
docs/multiuser/board_isolation_issue.mdfor detailed specification.QA Instructions
Test board isolation for regular users:
Test admin board visibility:
Test uncategorized board isolation:
Test state cleanup on user switch:
Merge Plan
N/A
Checklist
What's Newcopy (if doing a release after this PR)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.