Skip to content

Add 'Unpacked' Fields and Rows#256

Open
tomsmalley wants to merge 2 commits intolpsmith:masterfrom
obsidiansystems:unpacked-fields
Open

Add 'Unpacked' Fields and Rows#256
tomsmalley wants to merge 2 commits intolpsmith:masterfrom
obsidiansystems:unpacked-fields

Conversation

@tomsmalley
Copy link

Unpacked is probably a bad way of putting it (nothing to do with the pragma...)

This is for using the FromRow/FromField instances for data coming from outside of libpq - in particular, a replication connection. It allows us to build the Field and Row without involving libpq.

tomsmalley added 2 commits May 3, 2018 12:47
This is for using the FromRow/FromField instances for data coming from
outside of libpq - in particular, a replication connection.
import Database.PostgreSQL.Simple.Compat (scientificBuilder, (<>), toByteString)
import Database.PostgreSQL.Simple.FromField
import Database.PostgreSQL.Simple.Internal (setTypeOid)
import Database.PostgreSQL.Simple.Time
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think setTypeOid (and maybe some other things to manipulate the "unpacked" stuff?) should be made part of the public interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants