fix: undefined variable in conditioning warning#751
Open
Mr-Neutr0n wants to merge 1 commit intolllyasviel:mainfrom
Open
fix: undefined variable in conditioning warning#751Mr-Neutr0n wants to merge 1 commit intolllyasviel:mainfrom
Mr-Neutr0n wants to merge 1 commit intolllyasviel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Variable
cbsis referenced in a warning message but not defined in that scope, causing aNameErrorwhen the warning is triggered.In both
cldm/ddim_hacked.pyandldm/models/diffusion/ddim.py, theelif isinstance(conditioning, list)branch referencescbsin its warning print statement, butcbsis only defined in the precedingif isinstance(conditioning, dict)branch. When conditioning is a list and a batch size mismatch occurs, this raises aNameError.Fix
Replaced
cbswithctmp.shape[0]in the list conditioning branch, which is the correct value from the loop variable already being checked in the condition.