Updating SDKs with internal change of delete_login_factors mutation#58
Closed
joelweinberger wants to merge 1 commit intomainfrom
Closed
Updating SDKs with internal change of delete_login_factors mutation#58joelweinberger wants to merge 1 commit intomainfrom
joelweinberger wants to merge 1 commit intomainfrom
Conversation
joelweinberger
requested review from
a team and
bsiaotickchong
and removed request for
a team
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| entity(id: $entity_id) { | ||
| ... on Account { | ||
| transactions(, first: $first, after: $after, types: $types, after_date: $after_date, before_date: $before_date, bitcoin_network: $bitcoin_network, lightning_node_id: $lightning_node_id, statuses: $statuses, exclude_failures: $exclude_failures) { | ||
| transactions(, first: $first, after: $after, types: $types, after_date: $after_date, before_date: $before_date, bitcoin_network: $bitcoin_network, lightning_node_id: $lightning_node_id, statuses: $statuses, exclude_failures: $exclude_failures, max_amount: $max_amount, min_amount: $min_amount) { |
There was a problem hiding this comment.
There appears to be a stray comma after transactions( in the GraphQL query. This syntax error should be fixed by removing the comma:
transactions(first: $first, after: $after, ...)Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Comment on lines
+12
to
+13
| class CurrencyAmountInput: | ||
|
|
There was a problem hiding this comment.
Remove extra blank line between class declaration and first attribute to match Black formatting style
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| @dataclass | ||
| class AccountToApiTokensConnection(Connection): | ||
|
|
There was a problem hiding this comment.
Remove extra blank line after class declaration to match Black formatting
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.