Skip to content

chore: Update external account schemas from webdev#152

Open
lightspark-copybara[bot] wants to merge 1 commit intomainfrom
auto/sync-external-accounts-20260204-214934
Open

chore: Update external account schemas from webdev#152
lightspark-copybara[bot] wants to merge 1 commit intomainfrom
auto/sync-external-accounts-20260204-214934

Conversation

@lightspark-copybara
Copy link

Auto-synced external account schemas from webdev.

These schemas are generated from VASP adapter field definitions in sparkcore.

Please review the changes before merging.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 4, 2026

Greptile Overview

Greptile Summary

Auto-synced two new external account schemas from webdev for INR UPI and MXN SPEI payment corridors.

  • Added InrUpiAccountInfo.yaml for USD → INR via UPI with VPA field
  • Added MxnSpeiAccountInfo.yaml for USD → MXN via SPEI with 18-digit CLABE validation
  • Updated ExternalAccountInfoOneOf.yaml to include new account types in discriminator mappings
  • Normalized indentation from 2-space to consistent format across the oneOf list
  • Title naming inconsistency: new entries use schema names instead of human-readable format like existing entries

Confidence Score: 4/5

  • Safe to merge with minor style inconsistency that should be corrected
  • Auto-generated schemas are structurally correct with proper validation patterns, but title formatting deviates from established conventions
  • openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml (title formatting)

Important Files Changed

Filename Overview
openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml Added two new account types with formatting inconsistency in titles, plus indentation normalization
openapi/components/schemas/external_accounts/InrUpiAccountInfo.yaml New INR UPI account schema with proper structure and validation
openapi/components/schemas/external_accounts/MxnSpeiAccountInfo.yaml New MXN SPEI account schema with proper CLABE validation (18-digit pattern)

Sequence Diagram

sequenceDiagram
    participant WebDev as Webdev/Sparkcore
    participant CopyBot as Copybara Sync Bot
    participant GridAPI as Grid API Repo
    participant OpenAPI as OpenAPI Schema

    WebDev->>CopyBot: Generate external account schemas from VASP adapter
    Note over WebDev: MxnSpeiAccountInfo schema<br/>InrUpiAccountInfo schema
    CopyBot->>GridAPI: Auto-sync schemas
    GridAPI->>OpenAPI: Add InrUpiAccountInfo.yaml
    GridAPI->>OpenAPI: Add MxnSpeiAccountInfo.yaml
    GridAPI->>OpenAPI: Update ExternalAccountInfoOneOf.yaml
    Note over OpenAPI: Add INR_UPI_ACCOUNT mapping<br/>Add MXN_SPEI_ACCOUNT mapping<br/>Normalize indentation
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines +34 to +37
- title: MxnSpeiAccountInfo
$ref: ./MxnSpeiAccountInfo.yaml
- title: InrUpiAccountInfo
$ref: ./InrUpiAccountInfo.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent title format - should follow existing pattern like "SPEI Account" and "UPI Account" instead of schema names

Suggested change
- title: MxnSpeiAccountInfo
$ref: ./MxnSpeiAccountInfo.yaml
- title: InrUpiAccountInfo
$ref: ./InrUpiAccountInfo.yaml
- title: SPEI Account
$ref: ./MxnSpeiAccountInfo.yaml
- title: INR UPI Account
$ref: ./InrUpiAccountInfo.yaml

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 34:37

Comment:
Inconsistent title format - should follow existing pattern like "SPEI Account" and "UPI Account" instead of schema names

```suggestion
- title: SPEI Account
  $ref: ./MxnSpeiAccountInfo.yaml
- title: INR UPI Account
  $ref: ./InrUpiAccountInfo.yaml
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants