Switch ldk-server-client from reqwest to bitreq#127
Draft
Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Draft
Switch ldk-server-client from reqwest to bitreq#127Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
ldk-server-client from reqwest to bitreq#127Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
|
🔔 1st Reminder Hey @benthecarman! This PR has been waiting for your review. |
Collaborator
benthecarman
left a comment
benthecarman
left a comment
There was a problem hiding this comment.
We might want to hold off until ldk and ldk node have switched over for a clean break
| LdkServerError::new(InternalError, format!("Failed to read response body: {}", e)) | ||
| })?; | ||
| let status_code = response.status_code; | ||
| let is_success_status_code = || -> bool { (200..300).contains(&status_code) }; |
Collaborator
There was a problem hiding this comment.
Why is this a function?
| }; | ||
|
|
||
| const APPLICATION_OCTET_STREAM: &str = "application/octet-stream"; | ||
| const MAX_CACHED_CONNECTIONS: usize = 10; |
Collaborator
There was a problem hiding this comment.
Is this what they're doing in corepc? I feel like this could be a lot lower. Not a huge deal though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will switch
ldk-server-clientfrom using thereqwestdep to using the ecosystem maintained bitreq crate.Meanwhile, this will be in draft till rust-bitcoin/corepc#502 hopefully lands and released, so we can bring back ability to load custom root certificates.
Closes #119