Open
Conversation
Yurlungur
approved these changes
Aug 31, 2023
Collaborator
Yurlungur
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Collaborator
|
@rbberger could you take a look? |
rbberger
approved these changes
Aug 31, 2023
Collaborator
rbberger
left a comment
There was a problem hiding this comment.
Looks ok, although nothing actually sets entropy in EOSState.
Collaborator
|
Updated to main. Will merge if tests pass on re-git |
Collaborator
|
@AstroBarker this PR seems to fail when run on re-git with the full test buildout. Did you ever build the full python machinery when you tested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended code to expose the entropy functionality to the Python API.
Added two additional tests in
python_bindings.pythat check the entropy functionality in the [Vector EOS] bits.The Python binding stuff was a bit new to me, so I may well have missed something. It does work for the
IdealGasandStellarCollapsemodels as expected, though.make formatcommand after configuring withcmake.