Skip to content

fix: timers wake immediately on actor shutdown in threads module #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ElFantasma wants to merge 4 commits into
base: feature/ctrl-c-signal-handling
Choose a base branch
from
Open

fix: timers wake immediately on actor shutdown in threads module #142

ElFantasma wants to merge 4 commits into from

Conversation

@ElFantasma
Copy link
Collaborator

@ElFantasma ElFantasma commented Jan 26, 2026 •
edited
Loading

EDIT (28-01-2026):

Ran Devin review and fixed all found issues:
https://app.devin.ai/review/lambdaclass/spawned/pull/142

Summary

  • Add on_cancel() callback to CancellationToken for efficient waiting
  • Fix is_cancelled() bug that was clearing the flag
  • Change CancellationToken methods from &mut self to &self
  • Update send_after/send_interval to use channel-based wake pattern
  • Add test_send_after_actor_shutdown test

Closes #123

@ElFantasma ElFantasma mentioned this pull request Jan 27, 2026
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ElFantasma