ci: use lambdaclass/actions reusable workflows for AI review #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Kimi Code ReviewReview SummaryThis PR replaces individual AI review workflows with a unified approach using lambdaclass/actions reusable workflows. The changes are infrastructure-only and don't affect consensus-critical code. Issues Found1. Missing Secrets Validation (ai-review.yml:18-36)The workflow will fail silently if required secrets are missing. Add validation: - name: Validate secrets
run: |
if [ -z "${{ secrets.KIMI_API_KEY }}" ]; then
echo "::warning::KIMI_API_KEY not configured - Kimi reviews disabled"
fi
if [ -z "${{ secrets.OPENAI_API_KEY }}" ]; then
echo "::warning::OPENAI_API_KEY not configured - Codex reviews disabled"
fi
if [ -z "${{ secrets.ANTHROPIC_API_KEY }}" ]; then
echo "::warning::ANTHROPIC_API_KEY not configured - Claude reviews disabled"
fi2. Workflow Trigger Inconsistency (ai-review.yml:19-22)The new workflow triggers on
Fix: Add missing trigger types: types: [opened, synchronize, reopened, ready_for_review]3. Comment Trigger Support UnclearThe PR description mentions 4. Permission RegressionOld workflows had explicit
Verify these are set in the reusable workflows. Positive Changes✅ Cleaner maintenance - Single workflow file vs 3 separate ones RecommendationAddress the trigger inconsistency (#2) before merging - this is the only user-visible regression. Automated review by Kimi (Moonshot AI) · custom prompt |
🤖 Codex Code ReviewFindings
Consensus-layer review
If the reusable workflows already enforce trusted-commenter gating and set permissions internally, this looks fine. Automated review by OpenAI Codex · custom prompt |
Contributor
Greptile OverviewGreptile SummaryThis PR consolidates three separate AI review workflows (ChatGPT, Claude, Kimi) into a single unified workflow that uses reusable workflows from Key changes:
Critical behavioral change:
Other considerations:
Confidence Score: 3/5
|
| Filename | Overview |
|---|---|
| .github/workflows/ai-review.yml | New unified workflow using reusable workflows, but missing key configurations like permissions, concurrency control, and synchronize trigger |
Sequence Diagram
sequenceDiagram
participant User
participant GitHub
participant AI Review Workflow
participant Kimi Reusable WF
participant Codex Reusable WF
participant Claude Reusable WF
participant Kimi API
participant OpenAI API
participant Anthropic API
alt PR opened or ready_for_review
User->>GitHub: Open/Ready PR
GitHub->>AI Review Workflow: Trigger workflow
else On-demand via comment
User->>GitHub: Comment /kimi, /codex, or /claude
GitHub->>AI Review Workflow: Trigger workflow
end
par Parallel Reviews
AI Review Workflow->>Kimi Reusable WF: Call reusable workflow
Kimi Reusable WF->>Kimi API: Request review
Kimi API-->>Kimi Reusable WF: Return review
Kimi Reusable WF->>GitHub: Post review comment
and
AI Review Workflow->>Codex Reusable WF: Call reusable workflow
Codex Reusable WF->>OpenAI API: Request review
OpenAI API-->>Codex Reusable WF: Return review
Codex Reusable WF->>GitHub: Post review comment
and
AI Review Workflow->>Claude Reusable WF: Call reusable workflow
Claude Reusable WF->>Anthropic API: Request review
Anthropic API-->>Claude Reusable WF: Return review
Claude Reusable WF->>GitHub: Post review comment
end
GitHub-->>User: Display review comments
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+17
to
+18
| pull_request: | ||
| types: [opened, ready_for_review] |
Contributor
There was a problem hiding this comment.
Missing synchronize trigger - old workflows ran on PR updates (synchronize), this only runs on opened and ready_for_review
Suggested change
| pull_request: | |
| types: [opened, ready_for_review] | |
| pull_request: | |
| types: [opened, ready_for_review, synchronize] |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ai-review.yml
Line: 17:18
Comment:
Missing `synchronize` trigger - old workflows ran on PR updates (`synchronize`), this only runs on `opened` and `ready_for_review`
```suggestion
pull_request:
types: [opened, ready_for_review, synchronize]
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+14
to
+20
| name: AI Code Review | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, ready_for_review] | ||
| issue_comment: | ||
| types: [created] |
Contributor
There was a problem hiding this comment.
Check that permissions are correctly inherited from the reusable workflows - old workflows explicitly set contents: read, pull-requests: write (Claude also had issues: write and id-token: write)
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ai-review.yml
Line: 14:20
Comment:
Check that permissions are correctly inherited from the reusable workflows - old workflows explicitly set `contents: read`, `pull-requests: write` (Claude also had `issues: write` and `id-token: write`)
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+22
to
+36
| jobs: | ||
| kimi-review: | ||
| uses: lambdaclass/actions/.github/workflows/ai-review-kimi.yml@v1 | ||
| secrets: | ||
| KIMI_API_KEY: ${{ secrets.KIMI_API_KEY }} | ||
|
|
||
| codex-review: | ||
| uses: lambdaclass/actions/.github/workflows/ai-review-codex.yml@v1 | ||
| secrets: | ||
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
|
|
||
| claude-review: | ||
| uses: lambdaclass/actions/.github/workflows/ai-review-claude.yml@v1 | ||
| secrets: | ||
| ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }} |
Contributor
There was a problem hiding this comment.
Consider adding concurrency control to cancel in-progress runs when new commits are pushed, preventing wasted API credits:
Suggested change
| jobs: | |
| kimi-review: | |
| uses: lambdaclass/actions/.github/workflows/ai-review-kimi.yml@v1 | |
| secrets: | |
| KIMI_API_KEY: ${{ secrets.KIMI_API_KEY }} | |
| codex-review: | |
| uses: lambdaclass/actions/.github/workflows/ai-review-codex.yml@v1 | |
| secrets: | |
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | |
| claude-review: | |
| uses: lambdaclass/actions/.github/workflows/ai-review-claude.yml@v1 | |
| secrets: | |
| ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }} | |
| jobs: | |
| kimi-review: | |
| concurrency: | |
| group: ${{ github.workflow }}-kimi-${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: true | |
| uses: lambdaclass/actions/.github/workflows/ai-review-kimi.yml@v1 | |
| secrets: | |
| KIMI_API_KEY: ${{ secrets.KIMI_API_KEY }} | |
| codex-review: | |
| concurrency: | |
| group: ${{ github.workflow }}-codex-${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: true | |
| uses: lambdaclass/actions/.github/workflows/ai-review-codex.yml@v1 | |
| secrets: | |
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | |
| claude-review: | |
| concurrency: | |
| group: ${{ github.workflow }}-claude-${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: true | |
| uses: lambdaclass/actions/.github/workflows/ai-review-claude.yml@v1 | |
| secrets: | |
| ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }} |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ai-review.yml
Line: 22:36
Comment:
Consider adding concurrency control to cancel in-progress runs when new commits are pushed, preventing wasted API credits:
```suggestion
jobs:
kimi-review:
concurrency:
group: ${{ github.workflow }}-kimi-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
uses: lambdaclass/actions/.github/workflows/ai-review-kimi.yml@v1
secrets:
KIMI_API_KEY: ${{ secrets.KIMI_API_KEY }}
codex-review:
concurrency:
group: ${{ github.workflow }}-codex-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
uses: lambdaclass/actions/.github/workflows/ai-review-codex.yml@v1
secrets:
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
claude-review:
concurrency:
group: ${{ github.workflow }}-claude-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
uses: lambdaclass/actions/.github/workflows/ai-review-claude.yml@v1
secrets:
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/kimi,/codex,/claudecommandsChanges
.github/workflows/ai-review.yml- unified workflow using lambdaclass/actions@v1.github/prompts/pr_review.md→ai-review.mdpr_review_chatgpt.yaml,pr_review_claude.yaml,pr_review_kimi.yamlTest plan
/kimi,/codex,/claude)