Conversation
There was a problem hiding this comment.
💡 Codex Review
Lines 61 to 65 in 714dc23
package.json now sets main to out/index.js, but the files whitelist still only exports dist/**/*, index.js, and src/**/*.js (lines 61‑65), so npm pack/npm publish will drop the newly built out directory. Any install from the registry will lack out/index.js, and require('kuzzle-sdk') will fail with “Cannot find module '…/out/index.js'”. Add the out/** output (and declarations) to the files list to keep the published package loadable.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎉 This PR is included in version 7.16.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview