Version: Change go_version to based on runtime, add additional#50
Version: Change go_version to based on runtime, add additional#50directionless wants to merge 1 commit intokolide:mainfrom
Conversation
Given that go is statically compiled, I'm not sure why GoVersion is linked at build time, vs using runtime directly. Also, add it some additional runtime variables. While seemingly superfluous, these can add clarity in the rosetta2 environment.
|
I am not aware of any problem with the new approach. Perhaps the |
|
Not sure either. This change LGTM. |
| Version: version, | ||
| Branch: branch, | ||
| Revision: revision, | ||
| GoVersion: goVersion, |
There was a problem hiding this comment.
Should probable be a TODO to delete this global or mark it as deprecated? I understand not wanting to break any scripts still setting it.
There was a problem hiding this comment.
I swapped it runtime.Version(), which seems a little superfluous with calling runtime. but fits nicely with the PrintFull function. 🤷 Not sure this really gets any use
There was a problem hiding this comment.
My point is that the goVersion variable in the var block is now unused.
|
4 participants
Given that go is statically compiled, I'm not sure why GoVersion is linked at build time, vs using runtime directly.
Also, add it some additional runtime variables. While seemingly superfluous, these can add clarity in the rosetta2 environment.
@groob @zwass You both might know the history here. Is this a bad idea?