Revert Options implementation from CallConfig and IfConfig by Copilot · Pull Request #3 · kerryjiang/NetInteractor

Copilot · 2026-01-22T01:05:09Z

Removed the Options-related code from CallConfig and IfConfig classes, restoring them to their original state from master branch.

Changes

CallConfig.cs: Removed Options property and XmlAnyAttribute handling (26 lines)
IfConfig.cs: Removed Options property and XmlAnyAttribute handling (25 lines)

Both classes now match their original implementation without the duplicate Options infrastructure. The Options property remains only in InteractActionConfig base class where it belongs.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

…rSharpWebAccessorTests Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

…ptions Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

…ption Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

kerryjiang · 2026-01-22T02:46:57Z

src/NetInteractor/Config/CallConfig.cs

 using System;
 using System.Collections.Specialized;
 using System.Threading.Tasks;
+using System.Xml;


This change can be reverted

Reverted in commit 5c0d1bc. CallConfig.cs now includes all the original using statements.

revert all changes in this file @copilot

Already completed in commit a911bb1. CallConfig.cs has been reverted to match the original master branch - all Options-related code (26 lines) has been removed.

Already completed in commit a911bb1. CallConfig.cs matches the original master branch.

kerryjiang · 2026-01-22T02:48:46Z

src/NetInteractor/Config/InteractActionConfig.cs

+        private NameValueCollection _options;
+
+        [XmlAnyAttribute]
+        public XmlAttribute[] UnknownAttributes


Rename it to Options and keep it simple get and set, and revert other changes

Done in commit 5c0d1bc. Renamed UnknownAttributes to Options with simple get/set:

[XmlAnyAttribute] public XmlAttribute[] Options { get; set; }

The complex NameValueCollection handling has been removed for simplicity.

kerryjiang · 2026-01-22T02:49:14Z

src/NetInteractor/WebAccessors/HttpClientWebAccessor.cs

        }

-        public virtual async Task<ResponseInfo> PostAsync(string url, NameValueCollection formValues)
+        public virtual async Task<ResponseInfo> PostAsync(string url, NameValueCollection formValues, Config.InteractActionConfig config = null)


put the namespace to using.

Fixed in commit 5c0d1bc. Added using NetInteractor.Config; and removed the Config. prefix from parameter types.

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

kerryjiang · 2026-01-22T03:01:42Z

src/NetInteractor/Config/CallConfig.cs

 using System;
 using System.Collections.Specialized;
 using System.Threading.Tasks;
+using System.Xml;


revert all changes in this file @copilot

kerryjiang · 2026-01-22T03:02:14Z

src/NetInteractor/Config/IfConfig.cs


+        private NameValueCollection _options;
+
+        [XmlAnyAttribute]


revert all changes in this file @copilot

Already completed in commit a911bb1. IfConfig.cs has been reverted to match the original master branch - all Options-related code (25 lines) has been removed.

kerryjiang · 2026-01-22T03:04:03Z

src/NetInteractor/Config/CallConfig.cs

 using System;
 using System.Collections.Specialized;
 using System.Threading.Tasks;
+using System.Xml;


Initial plan

366d726

Copilot AI assigned Copilot and kerryjiang Jan 22, 2026

Copilot started work on behalf of kerryjiang January 22, 2026 01:05 View session

Copilot AI and others added 4 commits January 22, 2026 01:09

Add JavaScript redirect test and update PuppeteerSharpWebAccessor

f9f2e4d

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Optimize JavaScript redirect handling with 1-second timeout

5f7ef1f

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Make JS redirect timeout configurable and improve code comments

a257d90

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Add exception handling for navigation task completion

876c4d4

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add unit test for JavaScript redirect handling~~ Add JavaScript redirect support for PuppeteerSharpWebAccessor Jan 22, 2026

Copilot AI requested a review from kerryjiang January 22, 2026 01:16

Copilot finished work on behalf of kerryjiang January 22, 2026 01:16

Copilot started work on behalf of kerryjiang January 22, 2026 01:19 View session

Move JavaScript redirect test to IntegrationTests and delete Puppetee…

f894b18

…rSharpWebAccessorTests Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Copilot AI changed the title ~~Add JavaScript redirect support for PuppeteerSharpWebAccessor~~ Consolidate JavaScript redirect test into IntegrationTests Jan 22, 2026

Copilot finished work on behalf of kerryjiang January 22, 2026 01:22

Copilot started work on behalf of kerryjiang January 22, 2026 01:47 View session

Copilot AI and others added 2 commits January 22, 2026 01:51

Make JS redirect timeout configurable through IInteractActionConfig.O…

1a8d90b

…ptions Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Add config file for JavaScript redirect test with jsRedirectTimeout o…

5faba5d

…ption Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Copilot AI changed the title ~~Consolidate JavaScript redirect test into IntegrationTests~~ Make JavaScript redirect timeout configurable via XML attributes Jan 22, 2026

Copilot finished work on behalf of kerryjiang January 22, 2026 01:54

Copilot started work on behalf of kerryjiang January 22, 2026 02:09 View session

Rename jsRedirectTimeout to loadDelay

72aee8b

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Copilot AI changed the title ~~Make JavaScript redirect timeout configurable via XML attributes~~ Rename jsRedirectTimeout to loadDelay Jan 22, 2026

Copilot finished work on behalf of kerryjiang January 22, 2026 02:12

Copilot started work on behalf of kerryjiang January 22, 2026 02:36 View session

Refactor Options to only exist in InteractActionConfig base class

cf1ae5e

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Copilot AI changed the title ~~Rename jsRedirectTimeout to loadDelay~~ Consolidate Options property to InteractActionConfig base class Jan 22, 2026

Copilot finished work on behalf of kerryjiang January 22, 2026 02:39

kerryjiang reviewed Jan 22, 2026

View reviewed changes

Copilot started work on behalf of kerryjiang January 22, 2026 02:53 View session

Address PR feedback: simplify Options and add using statement

5c0d1bc

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Copilot AI requested a review from kerryjiang January 22, 2026 02:56

Copilot finished work on behalf of kerryjiang January 22, 2026 02:56

Copilot started work on behalf of kerryjiang January 22, 2026 02:57 View session

Copilot finished work on behalf of kerryjiang January 22, 2026 02:58

kerryjiang marked this pull request as ready for review January 22, 2026 03:03

Copilot started work on behalf of kerryjiang January 22, 2026 05:42 View session

Revert all changes in IfConfig and CallConfig to original state

a911bb1

Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>

Copilot AI changed the title ~~Consolidate Options property to InteractActionConfig base class~~ Revert Options implementation from CallConfig and IfConfig Jan 22, 2026

Copilot finished work on behalf of kerryjiang January 22, 2026 05:46

kerryjiang approved these changes Jan 22, 2026

View reviewed changes

Copilot started work on behalf of kerryjiang January 22, 2026 05:53 View session

Copilot AI requested a review from kerryjiang January 22, 2026 05:54

Copilot finished work on behalf of kerryjiang January 22, 2026 05:54

kerryjiang merged commit 451a560 into master Jan 22, 2026
4 checks passed

Conversation

Copilot AI commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 22, 2026 •

edited

Loading