feat: use swiftshader and egl-angle for headless chromium #123
Conversation
Update GPU rendering flags to use software rendering via SwiftShader with ANGLE's EGL backend for more consistent headless browser behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Suppresses the crash restore bubble UI in headless Chromium. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…tart When this test fails, it now logs: - The Chromium command and args being executed - The PID of the Chromium process - The UpstreamManager's debug logs - The full contents of the Chromium log file on failure This helps debug CI failures where the test times out waiting for the DevTools WebSocket URL to appear.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
quick question on the (the bugbot comment on #992 flagged something similar - just want to make sure we don't silently fall back to default GL rendering) |
masnwilliams
left a comment
masnwilliams
left a comment
There was a problem hiding this comment.
lgtm, just check out the comments re: the --use-gl flag value and the test logger potential panic
Address PR review comments: 1. Fix --use-gl flag: change from invalid 'egl-angle' to valid 'angle'. The 'egl-angle' value is an internal implementation name, not a valid command line flag. Valid values are: egl, angle, mock, stub, disabled. The correct SwANGLE config is --use-gl=angle --use-angle=swiftshader. 2. Fix potential panic in TestUpstreamManagerDetectsChromiumAndRestart: The testLogWriter now uses atomic.Bool to track when the test is done. After canceling the context, we stop the log writer before the test returns to prevent panics from the background tail goroutine logging after test completion.
Summary
--use-angleto--use-angle=swiftshaderfor software-based GPU rendering--use-gl=disabledto--use-gl=egl-angleto use ANGLE's EGL backendTest plan
🤖 Generated with Claude Code
Note
Updates headless Chromium flags and hardens devtools proxy tests.
--use-angle=swiftshader,--use-gl=angle, and add--hide-crash-restore-bubbleinwrapper.shtestLogWriter, safer teardown, extra logging, log dump on failures) forTestUpstreamManagerDetectsChromiumAndRestartWritten by Cursor Bugbot for commit d312592. This will update automatically on new commits. Configure here.