Skip to content

homelab storage#138

Merged
TabulateJarl8 merged 3 commits intomainfrom
homelabstorage
Feb 12, 2026
Merged

homelab storage#138
TabulateJarl8 merged 3 commits intomainfrom
homelabstorage

Conversation

@TabulateJarl8
Copy link
Member

ripley cant stop me

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Marp slide deck on homelab storage/backups (ZFS, RAID concepts, and BorgBackup) and links it from the repo README, including an additional screenshot asset used by the slides.

Changes:

  • Add homelab-storage/index.md slide deck covering storage fundamentals, ZFS, and backup strategies/tools.
  • Add homelab-storage/pika.png and reference it in the deck’s “Borg Frontends” slide.
  • Add a README entry linking to the new “Homelab Storage” deck.

Reviewed changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated 4 comments.

File Description
homelab-storage/index.md New Marp presentation content for storage/backups; includes command examples and images.
homelab-storage/pika.png New screenshot asset referenced by the slide deck.
README.md Adds the new deck to the list of full-length meetings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +157 to +161
-o ashift=12 \ # for modern 4KB sector drives. should be 13 for 8K sectors
-O compression=lz4 \ # or zstd, off, gzip
-O atime=off \ # performance/drive health
tank raidz1 \ # pool name and zfs config
/dev/disk/by-id/ata-DRIVE1_______ \ # list which drives make up the pool
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this shell snippet, the line continuations won’t work if someone copy/pastes: in POSIX shells the \ must be the last character on the line (no trailing spaces, and you can’t put an inline comment after it). Consider moving the comments onto their own lines (or above each option) and leaving the backslash as the final character.

Suggested change
-o ashift=12 \ # for modern 4KB sector drives. should be 13 for 8K sectors
-O compression=lz4 \ # or zstd, off, gzip
-O atime=off \ # performance/drive health
tank raidz1 \ # pool name and zfs config
/dev/disk/by-id/ata-DRIVE1_______ \ # list which drives make up the pool
# for modern 4KB sector drives. should be 13 for 8K sectors
-o ashift=12 \
# or zstd, off, gzip
-O compression=lz4 \
# performance/drive health
-O atime=off \
# pool name and zfs config
tank raidz1 \
# list which drives make up the pool
/dev/disk/by-id/ata-DRIVE1_______ \

Copilot uses AI. Check for mistakes.
Comment on lines +157 to +161
-o ashift=12 \ # for modern 4KB sector drives. should be 13 for 8K sectors
-O compression=lz4 \ # or zstd, off, gzip
-O atime=off \ # performance/drive health
tank raidz1 \ # pool name and zfs config
/dev/disk/by-id/ata-DRIVE1_______ \ # list which drives make up the pool
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue with line continuations here: there’s a backslash followed by an inline comment/spaces, which breaks the intended multiline zpool create command if pasted into a shell. Move comments to separate lines and keep \ as the last character on each continued line.

Suggested change
-o ashift=12 \ # for modern 4KB sector drives. should be 13 for 8K sectors
-O compression=lz4 \ # or zstd, off, gzip
-O atime=off \ # performance/drive health
tank raidz1 \ # pool name and zfs config
/dev/disk/by-id/ata-DRIVE1_______ \ # list which drives make up the pool
-o ashift=12 \
# for modern 4KB sector drives. should be 13 for 8K sectors
-O compression=lz4 \
# or zstd, off, gzip
-O atime=off \
# performance/drive health
tank raidz1 \
# pool name and zfs config
/dev/disk/by-id/ata-DRIVE1_______ \
# list which drives make up the pool

Copilot uses AI. Check for mistakes.
Comment on lines +172 to +174
sudo zpool create tank/backups
# optionally, change metadata:
sudo zpool set compression=zstd tank/backups
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is using zpool create/zpool set for dataset operations, but datasets are managed with zfs (e.g., zfs create tank/backups and zfs set compression=... tank/backups). As written, these commands will fail or do the wrong thing when followed literally.

Suggested change
sudo zpool create tank/backups
# optionally, change metadata:
sudo zpool set compression=zstd tank/backups
sudo zfs create tank/backups
# optionally, change metadata:
sudo zfs set compression=zstd tank/backups

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@TabulateJarl8 TabulateJarl8 merged commit 104ed35 into main Feb 12, 2026
2 checks passed
@TabulateJarl8 TabulateJarl8 deleted the homelabstorage branch February 12, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments