Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Marp slide deck on homelab storage/backups (ZFS, RAID concepts, and BorgBackup) and links it from the repo README, including an additional screenshot asset used by the slides.
Changes:
- Add
homelab-storage/index.mdslide deck covering storage fundamentals, ZFS, and backup strategies/tools. - Add
homelab-storage/pika.pngand reference it in the deck’s “Borg Frontends” slide. - Add a README entry linking to the new “Homelab Storage” deck.
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| homelab-storage/index.md | New Marp presentation content for storage/backups; includes command examples and images. |
| homelab-storage/pika.png | New screenshot asset referenced by the slide deck. |
| README.md | Adds the new deck to the list of full-length meetings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -o ashift=12 \ # for modern 4KB sector drives. should be 13 for 8K sectors | ||
| -O compression=lz4 \ # or zstd, off, gzip | ||
| -O atime=off \ # performance/drive health | ||
| tank raidz1 \ # pool name and zfs config | ||
| /dev/disk/by-id/ata-DRIVE1_______ \ # list which drives make up the pool |
There was a problem hiding this comment.
In this shell snippet, the line continuations won’t work if someone copy/pastes: in POSIX shells the \ must be the last character on the line (no trailing spaces, and you can’t put an inline comment after it). Consider moving the comments onto their own lines (or above each option) and leaving the backslash as the final character.
| -o ashift=12 \ # for modern 4KB sector drives. should be 13 for 8K sectors | |
| -O compression=lz4 \ # or zstd, off, gzip | |
| -O atime=off \ # performance/drive health | |
| tank raidz1 \ # pool name and zfs config | |
| /dev/disk/by-id/ata-DRIVE1_______ \ # list which drives make up the pool | |
| # for modern 4KB sector drives. should be 13 for 8K sectors | |
| -o ashift=12 \ | |
| # or zstd, off, gzip | |
| -O compression=lz4 \ | |
| # performance/drive health | |
| -O atime=off \ | |
| # pool name and zfs config | |
| tank raidz1 \ | |
| # list which drives make up the pool | |
| /dev/disk/by-id/ata-DRIVE1_______ \ |
| -o ashift=12 \ # for modern 4KB sector drives. should be 13 for 8K sectors | ||
| -O compression=lz4 \ # or zstd, off, gzip | ||
| -O atime=off \ # performance/drive health | ||
| tank raidz1 \ # pool name and zfs config | ||
| /dev/disk/by-id/ata-DRIVE1_______ \ # list which drives make up the pool |
There was a problem hiding this comment.
Same issue with line continuations here: there’s a backslash followed by an inline comment/spaces, which breaks the intended multiline zpool create command if pasted into a shell. Move comments to separate lines and keep \ as the last character on each continued line.
| -o ashift=12 \ # for modern 4KB sector drives. should be 13 for 8K sectors | |
| -O compression=lz4 \ # or zstd, off, gzip | |
| -O atime=off \ # performance/drive health | |
| tank raidz1 \ # pool name and zfs config | |
| /dev/disk/by-id/ata-DRIVE1_______ \ # list which drives make up the pool | |
| -o ashift=12 \ | |
| # for modern 4KB sector drives. should be 13 for 8K sectors | |
| -O compression=lz4 \ | |
| # or zstd, off, gzip | |
| -O atime=off \ | |
| # performance/drive health | |
| tank raidz1 \ | |
| # pool name and zfs config | |
| /dev/disk/by-id/ata-DRIVE1_______ \ | |
| # list which drives make up the pool |
| sudo zpool create tank/backups | ||
| # optionally, change metadata: | ||
| sudo zpool set compression=zstd tank/backups |
There was a problem hiding this comment.
This section is using zpool create/zpool set for dataset operations, but datasets are managed with zfs (e.g., zfs create tank/backups and zfs set compression=... tank/backups). As written, these commands will fail or do the wrong thing when followed literally.
| sudo zpool create tank/backups | |
| # optionally, change metadata: | |
| sudo zpool set compression=zstd tank/backups | |
| sudo zfs create tank/backups | |
| # optionally, change metadata: | |
| sudo zfs set compression=zstd tank/backups |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ripley cant stop me