More strict HTTP calls and better error handling#2
Open
holm wants to merge 23 commits intojmg:masterfrom
Open
Conversation
added 13 commits
March 22, 2012 14:49
Owner
|
Hey! i'm really glad you want to contribute to the project. I was seeing the changes and it all look great. I'll check it better and will make the marge definitely. |
Added get_picture_url method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to make quite a few changes to better handle errors. I switched to use the requests package instead of direct use of urllib, as it is much easier to work with.
I'm not sure you want this as there are quite a lot of changes, but thought you should have the option.