[_795] allow options to be accessed as attrs of metadata obj #796
Conversation
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Please address or explicitly ignore Ruff as you see fit.
| if n in _default_MetadataManager_opts: | ||
| return self._manager._opts[n] | ||
| raise AttributeError |
There was a problem hiding this comment.
The use of _default_MetadataManager_opts is a little confusing to me. Does this mean that we cannot access non-default options?
Does something like this improve the situation, or make it worse?
| if n in _default_MetadataManager_opts: | |
| return self._manager._opts[n] | |
| raise AttributeError | |
| if (attr := self._manager._opts.get(n)) is None: | |
| raise AttributeError(f"Attribute [{n}] not found") | |
| return attr |
There was a problem hiding this comment.
I tried it that way and got a never-ending recursion, unfortunately : (
|
|
||
|
|
||
| class iRODSMetaCollection: | ||
| def __getattr__(self,n): |
There was a problem hiding this comment.
Consider changing n to name or some other more descriptive parameter name.
| _default_MetadataManager_opts = { | ||
| 'admin':False, | ||
| 'timestamps':False, | ||
| 'iRODSMeta_type':iRODSMeta, | ||
| 'reload':True | ||
| } |
There was a problem hiding this comment.
What does this buy us over just... adding the new option to self._opts?
There was a problem hiding this comment.
Somehow doing it this way avoided a bottomless recursion. I do not know why....
2 participants
No description provided.