test: Add modexp test vectors for even modulus and edge cases #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test vectors for: - Small even modulus: 12, 20, 24 (single-byte results) - Power-of-two modulus larger than 64 bits - Large even modulus: (2^320-1)*2^64 and (2^768-1)*2^320 - Large base (48 bytes) with small even modulus (16 bytes) These cases exercise: - Even modulus handling via Chinese Remainder Theorem - modinv_pow2 Newton-Raphson iteration - Montgomery multiplication with base >= mod
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test vectors for modular exponentiation (modexp) to validate edge cases involving even moduli. The tests exercise the Chinese Remainder Theorem implementation, Newton-Raphson iteration for modular inverse with power-of-two moduli, and Montgomery multiplication with large bases.
Changes:
- Added test vectors for small even moduli (12, 20, 24) with single-byte results
- Added test for power-of-two modulus larger than 64 bits (2^96)
- Added tests for large even moduli: (2^320-1)*2^64 and (2^768-1)*2^320
- Added test for large base (48 bytes) with small even modulus (16 bytes)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
+ Coverage 81.64% 81.68% +0.03%
==========================================
Files 152 152
Lines 13550 13578 +28
Branches 3217 3217
==========================================
+ Hits 11063 11091 +28
Misses 343 343
Partials 2144 2144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test vectors for:
These cases exercise: