This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Add a config option to browserify-{es2015,typescript} to allow marking modules as external#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browserify externals cannot be configured via standard options therefore a special case is needed. With this change the user can modify the build process to split the code into app and vendor bundles.
The option location is a matter of opinion. I picked
options.browserifyOptions.externalas this is a Browserify-specific option but not a standard Browserify option so I can understand someone preferringoptions.externalinstead. I'm happy to alter the patch if you would prefer it this way.