fix(camera): set direction on web#665
Conversation
|
@Leo1305Pineda can you write tests with your PR ? Web RTC Camera is quite unstable on many environments, that would be great to not break it at every code update. |
|
@Leo1305Pineda do you plan to update your PR ? |
|
I have a build of this and it works fine for web, ios, and android. |
|
@Leo1305Pineda sure, we all have our custom fixes of web rtc camera, but would be really great to write a few tests to make it open-source friendly ;) |
|
This PR is also required pwa-elements/pull/93) |
|
@Leo1305Pineda have you tested it on a Microsoft Surface device? The devices API isn't standard (browser of Microsoft surface doesn't provide all the necessary metadata of devices). |
|
In pwa-elements there was no entry @prop () facesMode: FacingMode; |
|
@Leo1305Pineda thanks a lot, don't hesitate to make a quick test anyway with Microsoft Surface, facingMode doesn't work well with these devices. |
|
Thanks for the pull request! |
Is require PR to this from PR #93
Resolved open rear camera from initial opening.