Conversation
|
I'm not very familiar with prepend. Do you think we would be better off just checking the type and if it is time doing special handling or something? ie falling back to strftime instead of to_json/to_s? Might be safer. |
|
Thanks reply @geemus ! I completely agree with you. Your idea be safer than my change, but that change must be tough. I think to be not worth the effort and YAGNI. I feel there's a high possibility occurred in development environment only to those ploblems. Please forgive me my lousy English. |
|
I see, thanks for clarifying. I think we managed to avoid this as we use quotes around the timestamps (so they are treated as strings instead of timestamps when YAML parses them). This could work-around the issue at least. I see now why doing it the way I described wouldn't work and I also have a hard time seeing how to do it more simply or without a patch like this. I'm still concerned about possible side-effects or other issues to this kind of change though, so for now could you just quote to work-around? Thanks! |
Define
date-timevalidation format with RFC3339 in JSON Schema.I encounted problem, Prmd.combine return not valid format value.
from:
expect:
got:
I would like to merge this solution.
But, this solution abandoned under Ruby2.0 and a large range of influence cause use
prepend.If there is no problem to merge.