[INSTA-69727] Fysom improvement for multi-threaded operations #832
Conversation
CagriYonca
changed the title
|
The code is tested for gunicorn in amd64, arm64 and with autotrace-webhook. |
CagriYonca
changed the title
CagriYonca
force-pushed
the
fix-gunicorn
branch
3 times, most recently
from
e57efa4 to
8970564
Compare
CagriYonca
force-pushed
the
fix-gunicorn
branch
from
8970564 to
123f69b
Compare
CagriYonca
force-pushed
the
fix-gunicorn
branch
from
123f69b to
55842f5
Compare
CagriYonca
force-pushed
the
fix-gunicorn
branch
2 times, most recently
from
e46e111 to
7e6ce54
Compare
CagriYonca
force-pushed
the
fix-gunicorn
branch
from
7e6ce54 to
390837b
Compare
src/instana/agent/host.py
Outdated
| Forks happen. Here we handle them. | ||
| """ | ||
| # Update boot PID to current PID to prevent duplicate fork detection | ||
| self._boot_pid = os.getpid() |
There was a problem hiding this comment.
It looks like this variable is not used anywhere. Am I wrong?
There was a problem hiding this comment.
I didn't change anything regarding _boot_pid variable but it's used in can_send method to perform fork detection.
| if lock_acquired: | ||
| self.collector.background_report_lock.release() |
There was a problem hiding this comment.
I may not be following correctly, but why are you releasing the lock in a function that mainly prints a diagnostic of the agent?
There was a problem hiding this comment.
Normally, we were using the locked() method to check if the background_report_check is locked or not but as we moved to RLock, this new object doesn't have this method. We acquire the thread without blocking and release it immediately.
…nstrumentation Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
fix-gunicorn
branch
from
390837b to
da98753
Compare
|
3 participants
fysom.FysomError: event announce inappropriate in current state announcederror. After adding a thread-safe lock mechanism, it works and propagates spans as expected.