Fix pvc creation when existing pvc isn't used#207
Open
kastakhov wants to merge 2 commits intoimgproxy:masterfrom
Open
Fix pvc creation when existing pvc isn't used#207kastakhov wants to merge 2 commits intoimgproxy:masterfrom
kastakhov wants to merge 2 commits intoimgproxy:masterfrom
Conversation
Author
|
Hi @dragonsmith, could you check this PR? |
|
What about the |
Author
|
Hi @macropin, what do you mean? |
Collaborator
|
Hey. Thank you for your issue. Imgproxy is designed to serve images from a source and does not require a persistent volume to function. Therefore, we believe PV/PVC management is outside the scope of this chart and should be handled externally if needed. |
Author
|
Hi @gzigzigzeo, with this PR I'm fixing already existed functional (from PR #49), but not adding the new one. |
|
@kastakhov @gzigzigzeo for our use case we are serving images using |
Author
|
Hi @gzigzigzeo, just gently reminder about this PR. |
Collaborator
|
Hey @kastakhov, thanks, will get back to it on Wednesday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the #206 issue.