Add publisher confirms to support quorum queues.

[TreyE]

https://app.clickup.com/t/868gra3td

---

This pull request introduces several important updates focused on improving the reliability and consistency of AMQP message publishing by enabling publisher confirms throughout the codebase. Additionally, it upgrades Ruby to version 2.6.9 and updates related workflow and caching configurations. Below are the key changes grouped by theme:

AMQP Publisher Confirms and Reliability Improvements:

• Added publisher confirms (confirm_select and wait_for_confirms) to AMQP publishing channels in lib/acapi/amqp/client.rb, lib/acapi/amqp/requestor.rb, lib/acapi/amqp/responder.rb, and lib/acapi/local_amqp_publisher.rb to ensure that messages are reliably published and acknowledged by the broker. [1] [2] [3] [4] [5] [6] [7]

• Updated related specs in spec/lib/acapi/local_amqp_publisher_spec.rb to mock and test the new publisher confirm behavior. [1] [2]

Ruby Version and Workflow Updates:

• Upgraded Ruby version from 2.6.6 to 2.6.9 in .ruby-version and updated the Ruby version in the GitHub Actions workflow (.github/workflows/tests.yml). [1] [2]
• Updated the cache key in the workflow to match the new Ruby version and upgraded the cache action to actions/cache@v4.

Workflow Trigger Simplification:

• Simplified the workflow trigger for .github/workflows/downstream.yml by removing the branches filter from workflow_dispatch, so it now only triggers on pushes to trunk.

Connection Handling Fix:

• Improved connection handling in lib/acapi/requestor.rb to avoid unnecessary reconnections by checking if the Bunny connection is already established and connected before creating a new one.

[Copilot]

Pull request overview

This pull request adds publisher confirms support for RabbitMQ quorum queues, ensuring message delivery reliability through the publisher confirms pattern. The changes include creating separate publishing channels with confirm mode enabled, along with Ruby version updates and security dependency patches.

• Implements publisher confirms by calling confirm_select on publishing channels and wait_for_confirms after each publish operation
• Updates Ruby version from 2.6.6 to 2.6.9 for better stability and security
• Upgrades critical dependencies (nokogiri, loofah, crass) to address security vulnerabilities

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
lib/acapi/local_amqp_publisher.rb	Creates separate @p_channel for publishing with confirm_select enabled; adds wait_for_confirms after publish
lib/acapi/amqp/responder.rb	Adds confirm_select and wait_for_confirms to response exchange within with_response_exchange method
lib/acapi/amqp/requestor.rb	Creates dedicated p_channel for publishing with confirms; properly closes channel in ensure block
lib/acapi/amqp/client.rb	Establishes @republish_channel with confirms for redelivery scenarios
lib/acapi/requestor.rb	Improves connection check to verify both presence and connected status
spec/lib/acapi/local_amqp_publisher_spec.rb	Adds mocks for confirm_select and wait_for_confirms; changes create_channel expectation to allow for multiple channel creation
.ruby-version	Updates Ruby version from 2.6.6 to 2.6.9
.github/workflows/tests.yml	Updates Ruby version to 2.6.9 and upgrades actions/cache from v1 to v4
.github/workflows/downstream.yml	Removes branches filter from workflow_dispatch to allow manual runs from any branch
Gemfile.lock	Updates security-critical dependencies: crass, loofah, nokogiri, and adds racc

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[vkghub]

LGTM

Upgrade Ruby and enhance connection flexibility

• Updated Ruby version (patch upgrade).
• Added support for both single-host and multi-host (clustered) configurations.
• Implemented a dedicated publisher channel to support publisher confirmations.

[saipraveen18]

lgtm 👍