Add support for BYSETPOS (monthly and yearly frequency)#468
Add support for BYSETPOS (monthly and yearly frequency)#468joshbeckman wants to merge 5 commits intoice-cube-ruby:masterfrom
Conversation
In August 2016, @NicolasMarlier added BYSETPOS support (ice-cube-ruby#349). Then, in July 2018, @nehresma added a few small changes to run in modern Ruby and a more modern rspec (ice-cube-ruby#449). Then, in January 2019, @davidstosik and @k3rni suggested changes to reduce complexity. This incorporates all the above into a single diff.
Rubocop recommends cover? instead.
This is not available within the currently supported Rails versions Ref: https://apidock.com/rails/Hash/except
|
Note that currently, all logic is passing but some builds are failing due to (I believe): tzinfo/tzinfo#84 |
|
Looks like Travis has other problems, related to the Bundler version. You might want to rebase your branch on the latest master. |
|
I worked on the One of the specs I added actually fails, so I'd be curious to have others' opinion too. (And to see if all the specs I added pass in your implementation.) |
|
@davidstosik Thanks! I'll have a look at your branch. I branched off the latest master to add these changes, so I'm also not sure why bundler is complaining. I'm also trying to work on the |
|
I also like your more generic version of |
2 participants
In August 2016, @NicolasMarlier added BYSETPOS support (#349).
Then, in July 2018, @nehresma added a few small changes to run in modern Ruby and a more modern rspec (#449).
Then, in January 2019, @davidstosik and @k3rni suggested changes to reduce complexity.
This incorporates all the above into a single diff.